Merge pull request #23352 from eileenmcnaughton/leg

[civicrm-core.git] / Civi / Api4 / Generic / DAOUpdateAction.php

diff --git a/Civi/Api4/Generic/DAOUpdateAction.php b/Civi/Api4/Generic/DAOUpdateAction.php
index 9b3b6401d3d8bee78ae5acfcb7c26c4f392bdb60..25593822a6b70be6a9e645bacf3e481bbf4f7608 100644 (file)
--- a/Civi/Api4/Generic/DAOUpdateAction.php
+++ b/Civi/Api4/Generic/DAOUpdateAction.php
@@ -12,70 +12,23 @@
 
 namespace Civi\Api4\Generic;
 
-use Civi\API\Exception\UnauthorizedException;
-use Civi\Api4\Utils\CoreUtil;
-
 /**
  * Update one or more $ENTITY with new values.
  *
- * Use the `where` clause (required) to select them.
+ * Use the `where` clause to bulk update multiple records,
+ * or supply 'id' as a value to update a single record.
  */
 class DAOUpdateAction extends AbstractUpdateAction {
   use Traits\DAOActionTrait;
 
   /**
-   * Criteria for selecting items to update.
-   *
-   * Required if no id is supplied in values.
-   *
-   * @var array
-   */
-  protected $where = [];
-
-  /**
-   * @inheritDoc
+   * @param array $items
+   * @return array
+   * @throws \API_Exception
+   * @throws \CRM_Core_Exception
    */
-  public function _run(Result $result) {
-    $this->formatWriteValues($this->values);
-    // Add ID from values to WHERE clause and check for mismatch
-    if (!empty($this->values['id'])) {
-      $wheres = array_column($this->where, NULL, 0);
-      if (!isset($wheres['id'])) {
-        $this->addWhere('id', '=', $this->values['id']);
-      }
-      elseif (!($wheres['id'][1] === '=' && $wheres['id'][2] == $this->values['id'])) {
-        throw new \Exception("Cannot update the id of an existing " . $this->getEntityName() . '.');
-      }
-    }
-
-    // Require WHERE if we didn't get an ID from values
-    if (!$this->where) {
-      throw new \API_Exception('Parameter "where" is required unless an id is supplied in values.');
-    }
-
-    // Update a single record by ID unless select requires more than id
-    if ($this->getSelect() === ['id'] && count($this->where) === 1 && $this->where[0][0] === 'id' && $this->where[0][1] === '=' && !empty($this->where[0][2])) {
-      $this->values['id'] = $this->where[0][2];
-      if ($this->checkPermissions && !CoreUtil::checkAccessRecord($this, $this->values, \CRM_Core_Session::getLoggedInContactID() ?: 0)) {
-        throw new UnauthorizedException("ACL check failed");
-      }
-      $items = [$this->values];
-      $this->validateValues();
-      $result->exchangeArray($this->writeObjects($items));
-      return;
-    }
-
-    // Batch update 1 or more records based on WHERE clause
-    $items = $this->getBatchRecords();
-    foreach ($items as &$item) {
-      $item = $this->values + $item;
-      if ($this->checkPermissions && !CoreUtil::checkAccessRecord($this, $item, \CRM_Core_Session::getLoggedInContactID() ?: 0)) {
-        throw new UnauthorizedException("ACL check failed");
-      }
-    }
-
-    $this->validateValues();
-    $result->exchangeArray($this->writeObjects($items));
+  protected function updateRecords(array $items): array {
+    return $this->writeObjects($items);
   }
 
 }