Merge pull request #4533 from davecivicrm/CRM-15555

[civicrm-core.git] / CRM / Member / Form / MembershipType.php

diff --git a/CRM/Member/Form/MembershipType.php b/CRM/Member/Form/MembershipType.php
index 479ee08f415d1a1464fb9092e9a0f3029206440a..4cca8ce15d5ac581b042d85d5b363af5a6d55696 100644 (file)
--- a/CRM/Member/Form/MembershipType.php
+++ b/CRM/Member/Form/MembershipType.php
@@ -53,6 +53,8 @@ class CRM_Member_Form_MembershipType extends CRM_Member_Form {
     $session = CRM_Core_Session::singleton();
     $url = CRM_Utils_System::url('civicrm/admin/member/membershipType', 'reset=1');
     $session->pushUserContext($url);
+
+    $this->setPageTitle(ts('Membership Type'));
   }
 
   /**
@@ -132,7 +134,7 @@ class CRM_Member_Form_MembershipType extends CRM_Member_Form {
     );
     $this->addRule('minimum_fee', ts('Please enter a monetary value for the Minimum Fee.'), 'money');
 
-    $this->addSelect('duration_unit', array('placeholder' => NULL), TRUE);
+    $this->addSelect('duration_unit', array(), TRUE);
 
     //period type
     $this->addSelect('period_type', array(), TRUE);
@@ -182,6 +184,7 @@ class CRM_Member_Form_MembershipType extends CRM_Member_Form {
     $memberRel->setMultiple(TRUE);
 
     $this->addSelect('visibility', array('placeholder' => NULL, 'option_url' => NULL));
+
     $this->add('text', 'weight', ts('Order'),
       CRM_Core_DAO::getAttribute('CRM_Member_DAO_MembershipType', 'weight')
     );
@@ -411,6 +414,12 @@ class CRM_Member_Form_MembershipType extends CRM_Member_Form {
     }
   }
 
+  /**
+   * @param $previousID
+   * @param $priceSetId
+   * @param $membershipTypeId
+   * @param $optionsIds
+   */
   public static function checkPreviousPriceField($previousID, $priceSetId, $membershipTypeId, &$optionsIds) {
     if ($previousID) {
       $editedFieldParams = array(