Merge pull request #14004 from mfb/set-utf8

[civicrm-core.git] / CRM / Financial / BAO / FinancialItem.php

diff --git a/CRM/Financial/BAO/FinancialItem.php b/CRM/Financial/BAO/FinancialItem.php
index 60afb3f998434d433fb7eb4c356fa78171dc0fab..4e5ff50bbcf5321e6238c2c1bfbbb0c9a28ec9d7 100644 (file)
--- a/CRM/Financial/BAO/FinancialItem.php
+++ b/CRM/Financial/BAO/FinancialItem.php
@@ -89,7 +89,7 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem {
     elseif ($contribution->contribution_status_id == array_search('Partially paid', $contributionStatuses)) {
       $itemStatus = array_search('Partially paid', $financialItemStatus);
     }
-    $params = array(
+    $params = [
       'transaction_date' => CRM_Utils_Date::isoToMysql($contribution->receive_date),
       'contact_id' => $contribution->contact_id,
       'amount' => $lineItem->line_total,
@@ -98,7 +98,7 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem {
       'entity_id' => $lineItem->id,
       'description' => ($lineItem->qty != 1 ? $lineItem->qty . ' of ' : '') . $lineItem->label,
       'status_id' => $itemStatus,
-    );
+    ];
 
     if ($taxTrxnID) {
       $invoiceSettings = Civi::settings()->get('contribution_invoice_settings');
@@ -161,15 +161,15 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem {
     $financialtrxnIDS = CRM_Utils_Array::value('id', $trxnIds);
     if (!empty($financialtrxnIDS)) {
       if (!is_array($financialtrxnIDS)) {
-        $financialtrxnIDS = array($financialtrxnIDS);
+        $financialtrxnIDS = [$financialtrxnIDS];
       }
       foreach ($financialtrxnIDS as $tID) {
-        $entity_financial_trxn_params = array(
+        $entity_financial_trxn_params = [
           'entity_table' => "civicrm_financial_item",
           'entity_id' => $financialItem->id,
           'financial_trxn_id' => $tID,
           'amount' => $params['amount'],
-        );
+        ];
         if (!empty($ids['entityFinancialTrxnId'])) {
           $entity_financial_trxn_params['id'] = $ids['entityFinancialTrxnId'];
         }
@@ -220,13 +220,13 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem {
     }
     $financialItem->find();
     while ($financialItem->fetch()) {
-      $financialItems[$financialItem->id] = array(
+      $financialItems[$financialItem->id] = [
         'id' => $financialItem->id,
         'entity_table' => $financialItem->entity_table,
         'entity_id' => $financialItem->entity_id,
         'financial_trxn_id' => $financialItem->financial_trxn_id,
         'amount' => $financialItem->amount,
-      );
+      ];
     }
     if (!empty($financialItems)) {
       return $financialItems;
@@ -289,14 +289,14 @@ WHERE cc.id IN (' . implode(',', $contactIds) . ') AND con.is_test = 0';
    * @return array
    */
   public static function getPreviousFinancialItem($entityId) {
-    $params = array(
+    $params = [
       'entity_id' => $entityId,
       'entity_table' => 'civicrm_line_item',
-      'options' => array('limit' => 1, 'sort' => 'id DESC'),
-    );
-    $salesTaxFinancialAccounts = civicrm_api3('FinancialAccount', 'get', array('is_tax' => 1));
+      'options' => ['limit' => 1, 'sort' => 'id DESC'],
+    ];
+    $salesTaxFinancialAccounts = civicrm_api3('FinancialAccount', 'get', ['is_tax' => 1]);
     if ($salesTaxFinancialAccounts['count']) {
-      $params['financial_account_id'] = array('NOT IN' => array_keys($salesTaxFinancialAccounts['values']));
+      $params['financial_account_id'] = ['NOT IN' => array_keys($salesTaxFinancialAccounts['values'])];
     }
     return civicrm_api3('FinancialItem', 'getsingle', $params);
   }