*/
class CRM_Core_DAO extends DB_DataObject {
+ /**
+ * Primary key field(s).
+ *
+ * @var string[]
+ */
+ public static $_primaryKey = ['id'];
+
/**
* How many times has this instance been cloned.
*
*/
public static $_factory = NULL;
- public static $_checkedSqlFunctionsExist = FALSE;
-
/**
* https://issues.civicrm.org/jira/browse/CRM-17748
* internal variable for DAO to hold per-query settings
if (empty($record['id'])) {
throw new CRM_Core_Exception("Cannot delete {$entityName} with no id.");
}
+ CRM_Utils_Type::validate($record['id'], 'Positive');
CRM_Utils_Hook::pre('delete', $entityName, $record['id'], $record);
$instance = new $className();
Civi::service('sql_triggers')->rebuild($tableName, $force);
}
- /**
- * Because sql functions are sometimes lost, esp during db migration, we check here to avoid numerous support requests
- * @see http://issues.civicrm.org/jira/browse/CRM-13822
- * TODO: Alternative solutions might be
- * * Stop using functions and find another way to strip numeric characters from phones
- * * Give better error messages (currently a missing fn fatals with "unknown error")
- */
- public static function checkSqlFunctionsExist() {
- if (!self::$_checkedSqlFunctionsExist) {
- self::$_checkedSqlFunctionsExist = TRUE;
- $dao = CRM_Core_DAO::executeQuery("SHOW function status WHERE db = database() AND name = 'civicrm_strip_non_numeric'");
- if (!$dao->fetch()) {
- self::triggerRebuild();
- }
- }
- }
-
/**
* Wrapper function to drop triggers.
*
*/
public static function createSQLFilter($fieldName, $filter, $type = NULL, $alias = NULL, $returnSanitisedArray = FALSE) {
foreach ($filter as $operator => $criteria) {
- if (!CRM_Core_BAO_SchemaHandler::databaseSupportsUTF8MB4()) {
- foreach ((array) $criteria as $criterion) {
- if (!empty($criterion) && !is_numeric($criterion)
- // The first 2 criteria are redundant but are added as they
- // seem like they would
- // be quicker than this 3rd check.
- && max(array_map('ord', str_split($criterion))) >= 240) {
- // String contains unsupported emojis.
- // We return a clause that resolves to false as an emoji string by definition cannot be saved.
- // note that if we return just 0 for false if gets lost in empty checks.
- // https://stackoverflow.com/questions/16496554/can-php-detect-4-byte-encoded-utf8-chars
- return '0 = 1';
- }
- }
+ $emojiFilter = CRM_Utils_SQL::handleEmojiInQuery($criteria);
+ if ($emojiFilter === '0 = 1') {
+ return $emojiFilter;
}
if (in_array($operator, self::acceptedSQLOperators(), TRUE)) {