fix unused variable to not be a reference & default to an array per bao standards

[civicrm-core.git] / CRM / Core / BAO / File.php

diff --git a/CRM/Core/BAO/File.php b/CRM/Core/BAO/File.php
index 72ec638f925f5e7a12772716adc3ba23129d49ba..f09e64a11d19a4b036df80279b950588a8464dca 100644 (file)
--- a/CRM/Core/BAO/File.php
+++ b/CRM/Core/BAO/File.php
@@ -1,7 +1,7 @@
 <?php
  /*
   +--------------------------------------------------------------------+
-  | CiviCRM version 4.3                                                |
+  | CiviCRM version 4.4                                                |
   +--------------------------------------------------------------------+
   | Copyright CiviCRM LLC (c) 2004-2013                                |
   +--------------------------------------------------------------------+
@@ -284,7 +284,7 @@
      }
 
      //fix tag names
-     $tags = CRM_Core_PseudoConstant::tag();
+     $tags = CRM_Core_PseudoConstant::get('CRM_Core_DAO_EntityTag', 'tag_id', array('onlyActive' => FALSE));
 
      foreach($results as &$values) {
        if (!empty($values['tag'])) {
@@ -374,6 +374,7 @@
      // add attachments
      for ($i = 1; $i <= $numAttachments; $i++) {
        $form->addElement('file', "attachFile_$i", ts('Attach File'), 'size=30 maxlength=60');
+       $form->addUploadElement("attachFile_$i");
        $form->setMaxFileSize($maxFileSize * 1024 * 1024);
        $form->addRule("attachFile_$i",
          ts('File size should be less than %1 MByte(s)',