CRM-14106 - Regex targeting the first part of if statements

[civicrm-core.git] / CRM / Contact / BAO / RelationshipType.php

diff --git a/CRM/Contact/BAO/RelationshipType.php b/CRM/Contact/BAO/RelationshipType.php
index 3246acd89097b2ba31f8a77935c1fe8997a6677d..390a90dd5d6c0bcd448260544f14f5964ad87e64 100644 (file)
--- a/CRM/Contact/BAO/RelationshipType.php
+++ b/CRM/Contact/BAO/RelationshipType.php
@@ -92,21 +92,21 @@ class CRM_Contact_BAO_RelationshipType extends CRM_Contact_DAO_RelationshipType
    */
   static function add(&$params, &$ids) {
     //to change name, CRM-3336
-    if (!CRM_Utils_Array::value('label_a_b', $params) && CRM_Utils_Array::value('name_a_b', $params)) {
+    if (empty($params['label_a_b']) && CRM_Utils_Array::value('name_a_b', $params)) {
       $params['label_a_b'] = $params['name_a_b'];
     }
 
-    if (!CRM_Utils_Array::value('label_b_a', $params) && CRM_Utils_Array::value('name_b_a', $params)) {
+    if (empty($params['label_b_a']) && CRM_Utils_Array::value('name_b_a', $params)) {
       $params['label_b_a'] = $params['name_b_a'];
     }
 
     // set label to name if it's not set - but *only* for
     // ADD action. CRM-3336 as part from (CRM-3522)
-    if (!CRM_Utils_Array::value('relationshipType', $ids)) {
-      if (!CRM_Utils_Array::value('name_a_b', $params) && CRM_Utils_Array::value('label_a_b', $params)) {
+    if (empty($ids['relationshipType'])) {
+      if (empty($params['name_a_b']) && CRM_Utils_Array::value('label_a_b', $params)) {
         $params['name_a_b'] = $params['label_a_b'];
       }
-      if (!CRM_Utils_Array::value('name_b_a', $params) && CRM_Utils_Array::value('label_b_a', $params)) {
+      if (empty($params['name_b_a']) && CRM_Utils_Array::value('label_b_a', $params)) {
         $params['name_b_a'] = $params['label_b_a'];
       }
     }