$this->assign('context', $this->_context);
$this->_action = CRM_Utils_Request::retrieve('action', 'String', $this);
- $this->_campaignId = CRM_Utils_Request::retrieve('id', 'Positive', $this);
+ $this->_campaignId = CRM_Utils_Request::retrieve('id', 'Positive');
$title = NULL;
if ($this->_action & CRM_Core_Action::UPDATE) {
//load the values;
$this->_values = $this->get('values');
if (!is_array($this->_values)) {
- $this->_values = array();
+ $this->_values = [];
// if we are editing
if (isset($this->_campaignId) && $this->_campaignId) {
- $params = array('id' => $this->_campaignId);
+ $params = ['id' => $this->_campaignId];
CRM_Campaign_BAO_Campaign::retrieve($params, $this->_values);
}
$dao = new CRM_Campaign_DAO_CampaignGroup();
- $campaignGroups = array();
+ $campaignGroups = [];
$dao->campaign_id = $this->_campaignId;
$dao->find();
}
public function buildQuickForm() {
+ $this->add('hidden', 'id', $this->_campaignId);
if ($this->_action & CRM_Core_Action::DELETE) {
- $this->addButtons(array(
- array(
- 'type' => 'next',
- 'name' => ts('Delete'),
- 'isDefault' => TRUE,
- ),
- array(
- 'type' => 'cancel',
- 'name' => ts('Cancel'),
- ),
- )
- );
+ $this->addButtons([
+ [
+ 'type' => 'next',
+ 'name' => ts('Delete'),
+ 'isDefault' => TRUE,
+ ],
+ [
+ 'type' => 'cancel',
+ 'name' => ts('Cancel'),
+ ],
+ ]);
return;
}
$this->add('datepicker', 'end_date', ts('End Date'));
// add campaign type
- $this->addSelect('campaign_type_id', array('onChange' => "CRM.buildCustomData( 'Campaign', this.value );"), TRUE);
+ $this->addSelect('campaign_type_id', ['onChange' => "CRM.buildCustomData( 'Campaign', this.value );"], TRUE);
// add campaign status
$this->addSelect('status_id');
$campaigns = CRM_Campaign_BAO_Campaign::getCampaigns(CRM_Utils_Array::value('parent_id', $this->_values), $this->_campaignId);
if (!empty($campaigns)) {
$this->addElement('select', 'parent_id', ts('Parent ID'),
- array('' => ts('- select Parent -')) + $campaigns,
- array('class' => 'crm-select2')
+ ['' => ts('- select Parent -')] + $campaigns,
+ ['class' => 'crm-select2']
);
}
$groups = CRM_Core_PseudoConstant::nestedGroup();
ts('Include Group(s)'),
$groups,
FALSE,
- array(
+ [
'multiple' => TRUE,
'class' => 'crm-select2 huge',
'placeholder' => ts('- none -'),
- )
+ ]
);
- $this->add('wysiwyg', 'goal_general', ts('Campaign Goals'), array('rows' => 2, 'cols' => 40));
- $this->add('text', 'goal_revenue', ts('Revenue Goal'), array('size' => 8, 'maxlength' => 12));
+ $this->add('wysiwyg', 'goal_general', ts('Campaign Goals'), ['rows' => 2, 'cols' => 40]);
+ $this->add('text', 'goal_revenue', ts('Revenue Goal'), ['size' => 8, 'maxlength' => 12]);
$this->addRule('goal_revenue', ts('Please enter a valid money value (e.g. %1).',
- array(1 => CRM_Utils_Money::format('99.99', ' '))
+ [1 => CRM_Utils_Money::format('99.99', ' ')]
), 'money');
// is this Campaign active
$this->addElement('checkbox', 'is_active', ts('Is Active?'));
- $this->addButtons(array(
- array(
- 'type' => 'upload',
- 'name' => ts('Save'),
- 'isDefault' => TRUE,
- ),
- array(
- 'type' => 'upload',
- 'name' => ts('Save and New'),
- 'subName' => 'new',
- ),
- array(
- 'type' => 'cancel',
- 'name' => ts('Cancel'),
- ),
- )
- );
+ $buttons = [
+ [
+ 'type' => 'upload',
+ 'name' => ts('Save'),
+ 'isDefault' => TRUE,
+ ],
+ ];
+ // Skip this button when adding a new campaign from an entityRef
+ if (empty($_GET['snippet']) || empty($_GET['returnExtra'])) {
+ $buttons[] = [
+ 'type' => 'upload',
+ 'name' => ts('Save and New'),
+ 'subName' => 'new',
+ ];
+ }
+ $buttons[] = [
+ 'type' => 'cancel',
+ 'name' => ts('Cancel'),
+ ];
+
+ $this->addButtons($buttons);
}
/**
* @see valid_date
*/
public static function formRule($fields, $files, $errors) {
- $errors = array();
+ $errors = [];
return empty($errors) ? TRUE : $errors;
}
*/
public function postProcess() {
// store the submitted values in an array
- $params = $this->controller->exportValues($this->_name);
- $session = CRM_Core_Session::singleton();
- $groups = array();
- if (isset($this->_campaignId)) {
+ $session = CRM_Core_Session::singleton();
+ $params = $this->controller->exportValues($this->_name);
+ // To properly save the DAO we need to ensure we don't have a blank id key passed through.
+ if (empty($params['id'])) {
+ unset($params['id']);
+ }
+ if (!empty($params['id'])) {
if ($this->_action & CRM_Core_Action::DELETE) {
- CRM_Campaign_BAO_Campaign::del($this->_campaignId);
+ CRM_Campaign_BAO_Campaign::del($params['id']);
CRM_Core_Session::setStatus(ts('Campaign has been deleted.'), ts('Record Deleted'), 'success');
$session->replaceUserContext(CRM_Utils_System::url('civicrm/campaign', 'reset=1&subPage=campaign'));
return;
}
- $params['id'] = $this->_campaignId;
+ $this->_campaignId = $params['id'];
}
else {
$params['created_id'] = $session->get('userID');
$params['is_active'] = CRM_Utils_Array::value('is_active', $params, FALSE);
$params['last_modified_id'] = $session->get('userID');
$params['last_modified_date'] = date('YmdHis');
+ $result = self::submit($params, $this);
+ if (!$result['is_error']) {
+ CRM_Core_Session::setStatus(ts('Campaign %1 has been saved.', [1 => $result['values'][$result['id']]['title']]), ts('Saved'), 'success');
+ $session->pushUserContext(CRM_Utils_System::url('civicrm/campaign', 'reset=1&subPage=campaign'));
+ $this->ajaxResponse['id'] = $result['id'];
+ $this->ajaxResponse['label'] = $result['values'][$result['id']]['title'];
+ }
+ $buttonName = $this->controller->getButtonName();
+ if ($buttonName == $this->getButtonName('upload', 'new')) {
+ CRM_Core_Session::setStatus(ts(' You can add another Campaign.'), '', 'info');
+ $session->replaceUserContext(CRM_Utils_System::url('civicrm/campaign/add', 'reset=1&action=add'));
+ }
+ else {
+ $session->replaceUserContext(CRM_Utils_System::url('civicrm/campaign', 'reset=1&subPage=campaign'));
+ }
+ }
- if (is_array($params['includeGroups'])) {
+ public static function submit($params = [], $form) {
+ $groups = [];
+ if (!empty($params['includeGroups']) && is_array($params['includeGroups'])) {
foreach ($params['includeGroups'] as $key => $id) {
if ($id) {
$groups['include'][] = $id;
// delete previous includes/excludes, if campaign already existed
$groupTableName = CRM_Contact_BAO_Group::getTableName();
$dao = new CRM_Campaign_DAO_CampaignGroup();
- $dao->campaign_id = $this->_campaignId;
+ $dao->campaign_id = $form->_campaignId;
$dao->entity_table = $groupTableName;
$dao->find();
while ($dao->fetch()) {
CRM_Utils_Array::value('campaign_type_id', $params)
);
$params['custom'] = CRM_Core_BAO_CustomField::postProcess($params,
- $this->_campaignId,
+ $form->_campaignId,
'Campaign'
);
- $result = CRM_Campaign_BAO_Campaign::create($params);
-
- if ($result) {
- CRM_Core_Session::setStatus(ts('Campaign %1 has been saved.', array(1 => $result->title)), ts('Saved'), 'success');
- $session->pushUserContext(CRM_Utils_System::url('civicrm/campaign', 'reset=1&subPage=campaign'));
- }
-
- $buttonName = $this->controller->getButtonName();
- if ($buttonName == $this->getButtonName('upload', 'new')) {
- CRM_Core_Session::setStatus(ts(' You can add another Campaign.'), '', 'info');
- $session->replaceUserContext(CRM_Utils_System::url('civicrm/campaign/add', 'reset=1&action=add'));
- }
- else {
- $session->replaceUserContext(CRM_Utils_System::url('civicrm/campaign', 'reset=1&subPage=campaign'));
- }
+ // dev/core#1067 Clean Money before passing onto BAO to do the create.
+ $params['goal_revenue'] = CRM_Utils_Rule::cleanMoney($params['goal_revenue']);
+ $result = civicrm_api3('Campaign', 'create', $params);
+ return $result;
}
}
projects / civicrm-core.git / blobdiff