release-notes/5.6.0.md

   1 # CiviCRM 5.6.0
   2
   3 Released October 3, 2018
   4
   5 - **[Synopsis](#synopsis)**
   6 - **[Features](#features)**
   7 - **[Bugs resolved](#bugs)**
   8 - **[Miscellany](#misc)**
   9 - **[Credits](#credits)**
  10 - **[Feedback](#feedback)**
  11
  12 ## <a name="synopsis"></a>Synopsis
  13
  14 | *Does this version...?*                                         |         |
  15 |:--------------------------------------------------------------- |:-------:|
  16 | Fix security vulnerabilities?                                   |   no    |
  17 | Change the database schema?                                     |   no    |
  18 | Alter the API?                                                  | **yes** |
  19 | Require attention to configuration options?                     |   no    |
  20 | Fix problems installing or upgrading to a previous version?     |   no    |
  21 | Introduce features?                                             | **yes** |
  22 | Fix bugs?                                                       | **yes** |
  23
  24 ## <a name="features"></a>Features
  25
  26 ### Core CiviCRM
  27
  28 - **Activity display, switch to more performance getActivities function (from
  29   deprecatedGetActivities)
  30   ([12559](https://github.com/civicrm/civicrm-core/pull/12559))**
  31
  32   This change improves performance and alignment on the activity tab.
  33
  34 - **Upgrade symfony in lockfile to be 2.8 which is supported version of 2…
  35   ([12633](https://github.com/civicrm/civicrm-core/pull/12633))**
  36
  37   This change upgrades symfony from 2.6 to 2.8.44.
  38
  39 - **Improve styling of address block on summary screen
  40   ([12723](https://github.com/civicrm/civicrm-core/pull/12723))**
  41
  42   This changes the display of the address block to be more consistent with the
  43   way that email and website are displayed on a contact.
  44
  45 - **Foreign key for civicrm_custom_field.option_group_id
  46   ([12706](https://github.com/civicrm/civicrm-core/pull/12706))**
  47
  48   This change adds a foreign key for option group id to the custom field table.
  49
  50 - **Added Pseudoconstant for phone and website type
  51   ([12727](https://github.com/civicrm/civicrm-core/pull/12727))**
  52
  53   This Adds a Pseudoconstant for phone and website type.
  54
  55 - **Contact summary - adjust block width when editing
  56   ([12708](https://github.com/civicrm/civicrm-core/pull/12708))**
  57
  58   This makes it so that on the inline Contact edit form, when a user clicks to
  59   edit a section that section grows to allow the edit fields to be full sized.
  60
  61 - **Added Pseudoconstant tag for visibility
  62   ([12705](https://github.com/civicrm/civicrm-core/pull/12705))**
  63
  64   This change improves the API Explorer by adding a Pseudoconstant tag for
  65   visibility. This makes it so that civicrm_option_value.visibility_id is now a
  66   dropdown field with the visibility option group options.
  67
  68 - **Use static cache for UFMatch lookups to improve performance
  69   ([12628](https://github.com/civicrm/civicrm-core/pull/12628))**
  70
  71   This is a performance improvement, specifically it cuts down on load time for
  72   the contact summary page.
  73
  74 - **Replicate fix on PR #12643 for pledge report
  75   ([12685](https://github.com/civicrm/civicrm-core/pull/12685))**
  76
  77   This change makes it so on the "Pledged not Paid" report one can filter by
  78   smart groups.
  79
  80 - **[dev/core#217](https://lab.civicrm.org/dev/core/issues/217) Allow
  81   replacement of PrevNextCache implementation (for search screens)
  82   ([12664](https://github.com/civicrm/civicrm-core/pull/12664) and
  83   [12663](https://github.com/civicrm/civicrm-core/pull/12663)) (Preliminary Work)**
  84
  85   This change makes it so for the purposes of search-caching CiviCRM no longer
  86   fills or reads the columns 'entity_table' and 'entity_id2' in the
  87   civicrm_prevnext_cache table and makes the cacheKey column simpler and more
  88   consistent.
  89
  90 - **[dev/core#302](https://lab.civicrm.org/dev/core/issues/302) End of life
  91   plans for 5.x php versions & planning for 7.0 EOL
  92   ([12625](https://github.com/civicrm/civicrm-core/pull/12625)) (preliminary
  93   work)**
  94
  95   This change Bumps the recommended php version to 7.1 and min recommended to
  96   7.0
  97
  98 - **Add SQL modes to developer tab
  99   ([12656](https://github.com/civicrm/civicrm-core/pull/12656))**
 100
 101   This change adds SQL Mode info to the developer tab on reports.
 102
 103 - **don't add query to developer tab if we are downloading the data
 104   ([12666](https://github.com/civicrm/civicrm-core/pull/12666))**
 105
 106   This is a performance improvement for downloading reports for users who have
 107   permission to view the developer tab on reports.
 108
 109 - **filter current employer report by all groups
 110   ([12643](https://github.com/civicrm/civicrm-core/pull/12643))**
 111
 112   This change makes it so one can filter the Current Employer report by all
 113   groups. Prior to this change one could onlt filter this report by static
 114   groups.
 115
 116 ### CiviCase
 117
 118 - **Make contact name into a link on Manage Case for single client
 119   ([12619](https://github.com/civicrm/civicrm-core/pull/12619))**
 120
 121   On the Manage Case page for a single client, this change makes the contact
 122   name linked to that contact's summary page.
 123
 124 ### CiviContribute
 125
 126 - **Remove net_amount from the Back office contribution form.
 127   ([12662](https://github.com/civicrm/civicrm-core/pull/12662))**
 128
 129   This change removes the net amount field from the back office contribution
 130   form. The net amount is calculated in the BAO.
 131
 132 - **API : Set current domain as a sensible default for payment processor
 133   ([12595](https://github.com/civicrm/civicrm-core/pull/12595))**
 134
 135   This change improves the PaymentProcessor.create api action by making
 136   domain_id optional and setting it to use the current domain as the default if
 137   a domain_id is not sent.
 138
 139 ### CiviMember
 140
 141 - **Enable custom data display on MembershipType form
 142   ([12738](https://github.com/civicrm/civicrm-core/pull/12738))**
 143
 144   This makes it so if Membership Type custom fields are configured they are
 145   displayed on the Membership Type form.
 146
 147 ### Drupal Integration
 148
 149 - **[dev/core#237](https://lab.civicrm.org/dev/core/issues/237) Hide Drupal8
 150   Administer Menu bar on CiviCRM pages
 151   ([12463](https://github.com/civicrm/civicrm-core/pull/12463))**
 152
 153   This change hides the Drupal8 menu bar when a user is on a civi backend page.
 154
 155 - **Drupal Views CiviCRM: Allow Participant record to be used from Event.
 156   ([539](https://github.com/civicrm/civicrm-drupal/pull/539))**
 157
 158   This change makes it so in Drupal Views one can configure a relationship
 159   between CiviCRM Events and CiviCRM Participants.
 160
 161 ## <a name="bugs"></a>Bugs resolved
 162
 163 ### Core CiviCRM
 164
 165 - **Handle smart groups created in previous Civis which include
 166   relation_permission
 167   ([12804](https://github.com/civicrm/civicrm-core/pull/12804))**
 168
 169   This change fixes a bug where smart groups created in CiviCRM 5.4 based on a
 170   search using a relationship break in CiviCRM 5.5 so that they work as
 171   expected.
 172
 173 - **[dev/core#346](https://lab.civicrm.org/dev/core/issues/346) Online Pay Now
 174   error when used from dashboard checksum link
 175   ([12745](https://github.com/civicrm/civicrm-core/pull/12745))**
 176
 177   This change fixes a bug where when a user accessed the CiviCRM user dashboard
 178   using a checksum and then clicked the paynow link, the paynow link would
 179   break, so that the pay now link takes you to pay now as expected.
 180
 181 - **Show ext version status even when directory not writeable
 182   ([12757](https://github.com/civicrm/civicrm-core/pull/12757))**
 183
 184   This change fixes a bug where extension updates were not showing if the
 185   extension directory was not writable so that information about extension
 186   updates are shown on the extensions tab regardless of whether the extension
 187   directory is writabale.
 188
 189 - **Remove mcrypt warning except for affected sites.
 190   ([12733](https://github.com/civicrm/civicrm-core/pull/12733))**
 191
 192   This change makes it so that the System Check that warns people that mcrypt is
 193   not available only shows on sites that store smtp passwords in their database
 194   (the only users for whom this warning is applicable).
 195
 196 - **[dev/core#367](https://lab.civicrm.org/dev/core/issues/367) Fatal error /
 197   SQL timeout in A-Z pager for advanced search by relationship with target group
 198   for reciprocal relationship types
 199   ([12740](https://github.com/civicrm/civicrm-core/pull/12740))**
 200
 201   This change fixes a bug where advanced searches on reciprocal relationships
 202   (ex: "spouse") and using the criteria "target contact is in group" on sites
 203   with large numbers of relationships of that type would take a long time,
 204   occasionally timing out entirely.
 205
 206 - **[dev/core#343](https://lab.civicrm.org/dev/core/issues/343) Long lines in
 207   contact name or address overflow mailing labels
 208   ([12691](https://github.com/civicrm/civicrm-core/pull/12691))**
 209
 210   This change fixes a bug where PDF Mailing Labels generated by civi were not
 211   wrapping appropriately so that they wrap and do run off the label.
 212
 213 - **[dev/core#351](https://lab.civicrm.org/dev/core/issues/351) ERROR: LoadForm
 214   Pop-up w/out Params in URL
 215   ([12735](https://github.com/civicrm/civicrm-core/pull/12735))**
 216
 217   This change fixes a bug where the load form function used to open a form in a
 218   pop up window was throwing an error if no parameters were included in the URL
 219   so no error is thrown if no parameters are sent (and no parameters are
 220   necessary).
 221
 222 - **[dev/core#349](https://lab.civicrm.org/dev/core/issues/349) Scheduled
 223   reminders list default sort does not work
 224   ([12701](https://github.com/civicrm/civicrm-core/pull/12701))**
 225
 226   This change fixes the default sort of the Scheduled reminders list so that it
 227   sorts by title.
 228
 229 - **[dev/translation#14](https://lab.civicrm.org/dev/translation/issues/14)
 230   InnoDB Advanced Logging cannot be enabled on multi-lingual
 231   ([12667](https://github.com/civicrm/civicrm-core/pull/12667))**
 232
 233   This change makes it so that InnoDB Advanced Logging can be enabled on
 234   multi-lingual sites using:
 235   https://github.com/eileenmcnaughton/nz.co.fuzion.innodbtriggers
 236
 237 - **Fix recent item deduping & call hooks
 238   ([12704](https://github.com/civicrm/civicrm-core/pull/12704))**
 239
 240   This change fixes a bug where sometimes the same item would be added twice to
 241   the "recent items" list.
 242
 243 - **Wrap long labels onto multiple lines to prevent text being cut off
 244   ([12716](https://github.com/civicrm/civicrm-core/pull/12716))**
 245
 246   This change makes it so that on front facing forms, long labels wrap on to
 247   multiple lines.
 248
 249 - **Navigation - Don't reprocess fully-formed urls
 250   ([12702](https://github.com/civicrm/civicrm-core/pull/12702))**
 251
 252   This change fixes an edge case where fully-formed urls in the menubar were
 253   getting garbled so that relative urls, absolute urls and local urls are all
 254   processed correctly.
 255
 256 - **Fix CRM_ACL_API::whereClause to respect $contactId param
 257   ([12576](https://github.com/civicrm/civicrm-core/pull/12576))**
 258
 259   This adds support to the CMS based permission checking and ensures that
 260   CRM_ACL_API::whereClause checks the permissions for the contact Id it is sent
 261   (before this change it checked the permissions of the logged in user).
 262
 263 - **[dev/accessibility#10](https://lab.civicrm.org/dev/accessibility/issues/10)
 264   Make datepicker
 265   accessible ([12631](https://github.com/civicrm/civicrm-core/pull/12631)) (Preliminary Work)**
 266
 267   This change moves CiviCRM towards making the date picker accessible (one could
 268   select a date from the calendar using control keys without using a mouse) by
 269   moving the datepicker functionality to its own file.
 270
 271 - **[dev/core#295](https://lab.civicrm.org/dev/core/issues/295) Default 'from'
 272   mail address is not the default one showing in 'send email'
 273  ([12603](https://github.com/civicrm/civicrm-core/pull/12603))**
 274
 275   This change makes it so that when sending an email using the "send email"
 276   action if "Allow Mail to be sent from logged in contact's email address" is
 277   disabled in settings the default from address is loaded into the from address
 278   field.
 279
 280 - **Further removal of instance of using LOWER() rather than relying on mysql
 281   non-case-sensitivity.
 282   ([12612](https://github.com/civicrm/civicrm-core/pull/12612))**
 283
 284   This change improves performance when searching on email_greeting,
 285   postal_greeting, address.
 286
 287 - **Fix ReportInstance BAO to call post hook after save (instead of calling pre
 288   twice). ([12722](https://github.com/civicrm/civicrm-core/pull/12722))**
 289
 290   This change improves the hook functionality in the ReportInstance BAO so that
 291   one can call post hook after save and so that the pre hook is only called
 292   once.
 293
 294 ### CiviCase
 295
 296 - **[dev/core#297](https://lab.civicrm.org/dev/core/issues/297) permission
 297   "access my cases and activities" is broken by CRM-21461
 298   ([12613](https://github.com/civicrm/civicrm-core/pull/12613))**
 299
 300   This change fixes the permission "access my cases and activites".
 301
 302 - **[dev/core#361](https://lab.civicrm.org/dev/core/issues/361) Mistake in Case
 303   api spec description
 304   ([12726](https://github.com/civicrm/civicrm-core/pull/12726))**
 305
 306   This changes the text in the API Explorer for the entity Case for the
 307   parameter Tags to read "Find cases with specified tags." before this change it
 308   read "Find activities with specified tags.".
 309
 310 - **[dev/core#245](https://lab.civicrm.org/dev/core/issues/245) Duplicate
 311   activities shown on case tab
 312   ([12444](https://github.com/civicrm/civicrm-core/pull/12444))**
 313
 314   This change fixes a bug where If there were multiple assignee/target contacts on
 315   an activity, the activities were being duplicated on the case activities tab.
 316   Additionally this change fixes a bug where if the activity is only allowed a
 317   single instance and the user tried to add another, the link had an invalid
 318   activity Id.
 319
 320 - **Don't duplicate activity when filing on case
 321   ([12620](https://github.com/civicrm/civicrm-core/pull/12620))**
 322
 323   This change fixes a bug where filing an activity on a case using the "File On
 324   Case" link on the actvitytab/activity detail view  would result in two
 325   activities one related to the case and one not.
 326
 327 ### CiviContribute
 328
 329 - **[dev/core#299](https://lab.civicrm.org/dev/core/issues/299) Decimal point
 330   error. ([12684](https://github.com/civicrm/civicrm-core/pull/12684))
 331   (Continuation of work)**
 332
 333   This change localizes the display of the amount on the update payment details
 334   form.
 335
 336 - **[dev/core#334](https://lab.civicrm.org/dev/core/issues/334) Public
 337   contribution form and Checksums: billing information not loaded if using
 338   multiple processors
 339   ([12679](https://github.com/civicrm/civicrm-core/pull/12679))**
 340
 341   This fixes a bug where when a user goes to a contribution page that is
 342   configured to use multiple payment processors via a checksum link the billing
 343   address section was not pre-populating so that the billing section does
 344   pre-populate.
 345
 346 - **[dev/core#119](https://lab.civicrm.org/dev/core/issues/119) Notice error
 347   ([12626](https://github.com/civicrm/civicrm-core/pull/12626))**
 348
 349   When recording a payment on a site that is configured not to use decimal
 350   thousand separators, that configuration was not being respected for the
 351   default amount. This change fixes the default amount to be localized
 352   appropriately.
 353
 354 - **[dev/core#322](https://lab.civicrm.org/dev/core/issues/322) Contribution
 355   page, completing this form on behalf of someone else: JavaScript error for
 356   checkbox field ([12652](https://github.com/civicrm/civicrm-core/pull/12652))**
 357
 358   This fixes a bug on contribution pages configured to accept donations onbehalf
 359   of someone else and to include a profile with a checkbox where checking the
 360   checkbox in the profile would result in a javascript error, additionally it
 361   ensures that the form is  populated with the onbehalf of contact's data.
 362
 363 - **Use cached version of payment processor.
 364   ([12627](https://github.com/civicrm/civicrm-core/pull/12627))**
 365
 366   This change fixes a bug where some payment processors when combined with Redis
 367   were failing to complete transactions because Redis was caching the call to
 368   completetransaction.
 369
 370 - **[dev/core#325](https://lab.civicrm.org/dev/core/issues/325) Fatal error 'DB Error: no
 371   such field' on Contribution detail report
 372   ([12660](https://github.com/civicrm/civicrm-core/pull/12660))**
 373
 374   This change fixes a bug where on the Contribution Detail report, selecting the
 375   "Age" column would result in a fatal error so that the report includes Age as
 376   expected.
 377
 378 - **[dev/core#386](https://lab.civicrm.org/dev/core/issues/386)
 379   Contribution Detail Report shows no amount if set to Soft Credit Only
 380   ([12860](https://github.com/civicrm/civicrm-core/pull/12860))**
 381
 382 - **[dev/core#341](https://lab.civicrm.org/dev/core/issues/341) "Contributions
 383   made in Year X and not Year Y" custom search ignores date field
 384   ([12686](https://github.com/civicrm/civicrm-core/pull/12686))**
 385
 386   This fixes a bug where custom searches using the "Contributions made in Year X
 387   and not Year Y" were not respecting the date parameters, so that date
 388   parameters are respected.
 389
 390 - **[dev/core#327](https://lab.civicrm.org/dev/core/issues/327) PHP Fatal error:
 391   Call to undefined method - Contribution Details report
 392   ([12661](https://github.com/civicrm/civicrm-core/pull/12661))**
 393
 394   This fixes a bug where checking the Gender column field on the Contribution
 395   Details report resulted in a fatal error so that one can include a gender
 396   column in this report.
 397
 398 ### CiviEvent
 399
 400 - **Fix Undefined index: params in CRM_Event_BAO_Event::buildCustomProfile()
 401   ([12678](https://github.com/civicrm/civicrm-core/pull/12678))**
 402
 403   This change suppresses an undefined index notice that was showing when one
 404   comes to an Event from an online payment provider.
 405
 406 - **[dev/core#344](https://lab.civicrm.org/dev/core/issues/344) Tell a Friend
 407   mail does not include event title
 408   ([12699](https://github.com/civicrm/civicrm-core/pull/12699))**
 409
 410   This fixes a bug where when using the Tell-A-Friend option to send an email
 411   the title of the event was appearing in the subject of the email, so that the
 412   title of the event does appear in the subject of the email.
 413
 414 - **Ensure users with the perm "CiviEvent: access CiviEvent " can edit events
 415   they have created.
 416   ([12424](https://github.com/civicrm/civicrm-core/pull/12424))**
 417
 418   This change fixes a bug where users with the permission "CiviEvent: access
 419   CiviEvent" could create but not edit their events so that they can create and
 420   edit their events.
 421
 422 - **GL-44 Admin price field options on event info page
 423   ([11923](https://github.com/civicrm/civicrm-core/pull/11923))**
 424
 425   This change ensures that on event info pages price set field options with the
 426   visibility "admin" are only shown to admins.
 427
 428 ### CiviMail
 429
 430 - **[dev/mail#20](https://lab.civicrm.org/dev/mail/issues/20) Preview screen
 431   don't open until recipients list is built on mail compose screen
 432   ([12509](https://github.com/civicrm/civicrm-core/pull/12509))**
 433
 434   This change fixes a bug where when drafting a mailing one could not open the
 435   preview mailing screen until the recipient count query had completed.
 436
 437 - **[dev/core#352](https://lab.civicrm.org/dev/core/issues/352) Ensure that when
 438   adding recipients of previous mailings that contacts who are being excluded
 439   are removed ([12712](https://github.com/civicrm/civicrm-core/pull/12712))**
 440
 441   This change makes sure when using recipients from a previous mailing as the
 442   recipients of a mailing That any exclusions are respected.
 443
 444 - **[dev/mail#21](https://lab.civicrm.org/dev/mail/issues/21) "Send test email"
 445   may create duplicate contacts
 446   ([12599](https://github.com/civicrm/civicrm-core/pull/12599))**
 447
 448   This change fixes a bug where sending a test email to two contacts seperated
 449   by a space and a comma would sometimes result in a duplicate contact being
 450   created.
 451
 452 - **pass mailingJobId to hook_tokenValues
 453   ([12026](https://github.com/civicrm/civicrm-core/pull/12026))**
 454
 455   This change ensures the mailingJobId is sent to hook_tokenValues.
 456
 457 ### CiviMember
 458
 459 - **BASW-240: 'Network Error' when creating membership type from contact
 460   membership tab ([12700](https://github.com/civicrm/civicrm-core/pull/12700))**
 461
 462   This Change fixes a Network Error that was appearing when creating a membership
 463   type from a contacts membership tab.
 464
 465 ### Drupal Integration
 466
 467 - **[dev/core#311](https://lab.civicrm.org/dev/core/issues/311) Upgrading
 468   multilingual site causes DB Error
 469   ([12636](https://github.com/civicrm/civicrm-core/pull/12636))**
 470
 471   This change fixes a bug where upgrading a multilingual drupal site from
 472   CiviCRM 4.4.7 to 5.4.0 causes a DB error so that one can upgrade a
 473   multilingual drupal site without a DB error.
 474
 475 ### Joomla Integration
 476
 477 - **[dev/joomla#2](https://lab.civicrm.org/dev/joomla/issues/2) Joomla
 478   cron.php/cli.php fail on Windows server
 479   ([12692](https://github.com/civicrm/civicrm-core/pull/12692))**
 480
 481   This fixes a bug where on Joomla sites on Windows cron was failing so that
 482   cron works for Joomla stes on Windows.
 483
 484 - **Make sure Joomla timezone is set for cron jobs
 485   ([12609](https://github.com/civicrm/civicrm-core/pull/12609))**
 486
 487   This change ensures that the CRON job is executed using the same timezone as
 488   Joomla (and the same timezone that is configured for Joomla/CiviCRM/database
 489   when running via web). Prior to this change the CRON job was being executed
 490   with timezone set to UTC.
 491
 492 ## <a name="misc"></a>Miscellany
 493
 494 - **Stop passing imProviders & phoneTypes - use CRM_Core_PseudoConstant:getLabel
 495   ([12608](https://github.com/civicrm/civicrm-core/pull/12608))**
 496
 497 - **Remove unused variables from process_participants job
 498   ([12621](https://github.com/civicrm/civicrm-core/pull/12621))**
 499
 500 - **Follow up on #12611 - adding in three data-integrity assertions.
 501   ([12629](https://github.com/civicrm/civicrm-core/pull/12629))**
 502
 503 - **Minor refactor, use sales tax trait to simplify sales tax functions
 504   ([12594](https://github.com/civicrm/civicrm-core/pull/12594))**
 505
 506 - **Drop custom CSS for Joomla CiviCRM menu so it works with shoreditch theme
 507   ([12632](https://github.com/civicrm/civicrm-core/pull/12632))**
 508
 509 - **Export minor refactor Move household relationship types to the processor
 510   ([12579](https://github.com/civicrm/civicrm-core/pull/12579))**
 511
 512 - **Code cleanup on Membership form when freezing fields in a recurring exists
 513   situation ([12642](https://github.com/civicrm/civicrm-core/pull/12642))**
 514
 515 - **Add test for new rounded money format functions
 516   ([12689](https://github.com/civicrm/civicrm-core/pull/12689))**
 517
 518 - **Minor comment and typo cleanup
 519   ([12715](https://github.com/civicrm/civicrm-core/pull/12715))**
 520
 521 - **Towards rationalising settings form & preferences form (partial of 12731)
 522   ([12732](https://github.com/civicrm/civicrm-core/pull/12732))**
 523
 524 - **Fix compatibility problem with CRM_Extendedreport_Form_Report_ExtendedReport
 525   ([12749](https://github.com/civicrm/civicrm-core/pull/12749))**
 526
 527 - **Fix teeny typo
 528   ([12618](https://github.com/civicrm/civicrm-core/pull/12618))**
 529
 530 - **[PHPUnit test only] Adding in assertions re: Line Item and Contribution
 531   data-integrity.
 532   ([12611](https://github.com/civicrm/civicrm-core/pull/12611))**
 533
 534 - **[NFC] comment fixes relating to doc blocks, spelling
 535   ([12630](https://github.com/civicrm/civicrm-core/pull/12630))**
 536
 537 - **[phpunit test only] - Add one additional data integrity check to ensure that
 538   after Edit Fin…
 539   ([12645](https://github.com/civicrm/civicrm-core/pull/12645))**
 540
 541 - **NFC Add/update two comments
 542   ([12680](https://github.com/civicrm/civicrm-core/pull/12680))**
 543
 544 - **[NFC] Minor function extraction in report class.
 545   ([12658](https://github.com/civicrm/civicrm-core/pull/12658))**
 546
 547 - **(NFC) Fix incorrect reference of doTransferCheckout() in comments
 548   ([12720](https://github.com/civicrm/civicrm-core/pull/12720))**
 549
 550 - **NFC cleanup to Membership/Renewal form classes.
 551   ([12696](https://github.com/civicrm/civicrm-core/pull/12696))**
 552
 553 - **[CRM-21677](https://issues.civicrm.org/jira/browse/CRM-21677) Report
 554   improvements ([12703](https://github.com/civicrm/civicrm-core/pull/12703) and
 555   [12698](https://github.com/civicrm/civicrm-core/pull/12698))**
 556
 557 - **Deduplicate setting of mailSent message
 558   ([12694](https://github.com/civicrm/civicrm-core/pull/12694))**
 559
 560 - **Setting form - function extraction
 561   ([12744](https://github.com/civicrm/civicrm-core/pull/12744))**
 562
 563 ## <a name="credits"></a>Credits
 564
 565 This release was developed by the following code authors:
 566
 567 AGH Strategies - Alice Frumin, Andrew Hunt; Andrew Thompson; Australian Greens -
 568 Seamus Lee; Calbasi - Joan Cervan Andreu; Calibrate - Wouter Hechtermans; Chris
 569 Burgess; Circle Interactive - Dave Jenkins; CiviCoop - Klaas Eikelboom; CiviCRM -
 570 Coleman Watts, Tim Otten; CiviDesk - Yashodha Chaku; CiviFirst - John Kirk;
 571 CompuCorp - Vinu Varshith Sekar; Coop SymbioTIC - Mathieu Lutfy; Fuzion -
 572 Jitendra Purohit; JMA Consulting - Monish Deb; John Kingsnorth; Joinery - Allen
 573 Shaw; Lemniscus - Noah Miller; Lighthouse Design and Consulting - Brian
 574 Shaughnessy; Megaphone Technology Consulting - Jon Goldberg; MillerTech - Chamil
 575 Wijesooriya; MJW Consulting - Matthew Wire; PHD Computer Consultants - Chris
 576 Cant; Pradeep Nayak; Progressive Technology Project - Jamie McClelland; Richard
 577 van Oosterhout; Selwyn Tang; Semper IT - Karin Gerritsen; Third Sector Design -
 578 Michael McAndrew; Wikimedia Foundation - Eileen McNaughton
 579
 580 Most authors also reviewed code for this release; in addition, the following
 581 reviewers contributed their comments:
 582
 583 Agileware - Justin Freeman; Fuzion - Peter Davis; JMA Consulting - Joe Murray;
 584 MillerTech - Chamil Wijesooriya; Oxfam Germany - Thomas Schüttler; sleewok;
 585 Squiffle Consulting - Aidan Saunders
 586
 587 ## <a name="feedback"></a>Feedback
 588
 589 These release notes are edited by Alice Frumin and Andrew Hunt.  If you'd like
 590 to provide feedback on them, please log in to https://chat.civicrm.org/civicrm
 591 and contact `@agh1`.