3 Released September 5, 2018
5 - **[Synopsis](#synopsis)**
6 - **[Features](#features)**
7 - **[Bugs resolved](#bugs)**
8 - **[Miscellany](#misc)**
9 - **[Credits](#credits)**
10 - **[Feedback](#feedback)**
12 ## <a name="synopsis"></a>Synopsis
14 | *Does this version...?* | |
15 |:--------------------------------------------------------------- |:-------:|
16 | Fix security vulnerabilities? | no |
17 | Change the database schema? | no |
18 | Alter the API? | **yes** |
19 | Require attention to configuration options? | no |
20 | Fix problems installing or upgrading to a previous version? | **yes** |
21 | Introduce features? | **yes** |
22 | Fix bugs? | **yes** |
24 ## <a name="features"></a>Features
28 - **Further fix for updating custom fields linked to optiongroups.
29 ([12729](https://github.com/civicrm/civicrm-core/pull/12729))**
31 This change makes it so when a user is editing a custom field that uses option
32 groups, the select field for option groups shows all non-reserved option
33 groups. Before this change only the selected option group was displayed.
35 - **Upgrader - When updating message templates, identify them by name
36 ([12674](https://github.com/civicrm/civicrm-core/pull/12674))**
38 On the Upgrade screen, when a change has been made to a message template, this
39 change makes it so that the name of the message template is included in the
42 - **Refine upgrade message for `save Report Criteria`
43 ([12670](https://github.com/civicrm/civicrm-core/pull/12670))**
45 This change alters the update message for "save Report Criteria" to be more
48 - **[dev/core#217](https://lab.civicrm.org/dev/core/issues/217) Allow
49 replacement of PrevNextCache implementation (for search screens)
50 ([12558](https://github.com/civicrm/civicrm-core/pull/12558),
51 [12556](https://github.com/civicrm/civicrm-core/pull/12556),
52 [12543](https://github.com/civicrm/civicrm-core/pull/12543),
53 [12544](https://github.com/civicrm/civicrm-core/pull/12544),
54 [12545](https://github.com/civicrm/civicrm-core/pull/12545),
55 [12528](https://github.com/civicrm/civicrm-core/pull/12528),
56 [12438](https://github.com/civicrm/civicrm-core/pull/12438)) (preliminary
59 Preliminary work to allow contact searches to retain their results via
60 Redis/Memcache (instead of MySQL).
62 - **Export - add tests out header output, move phone_type_id to metadata
63 ([12587](https://github.com/civicrm/civicrm-core/pull/12587))**
65 This change makes it so one can export phone_type_id.
67 - **api - CustomValue::get - add handling for comma separated return fields
68 ([12604](https://github.com/civicrm/civicrm-core/pull/12604))**
70 This change makes it so twhen using the CustomValue get api accepts comma
71 separated return fields.
73 - **[dev/core#291](https://lab.civicrm.org/dev/core/issues/291) Allow password
74 field sizes to be set in props a la text fields
75 ([12589](https://github.com/civicrm/civicrm-core/pull/12589))**
77 This change makes it so password fields can be any size. Prior to this change
78 password fields were all the same size.
80 - **Entity form : Establish methodology to allow default values to be passed in
81 on the url ([12185](https://github.com/civicrm/civicrm-core/pull/12185))**
83 This change makes it so that some values can be passed thru the url for more
84 information see: [dev/core#115](https://lab.civicrm.org/dev/core/issues/115).
86 - **[dev/core#244](https://lab.civicrm.org/dev/core/issues/244) Allow use of
87 custom fields of type select without specifying an optiongroup
88 ([12440](https://github.com/civicrm/civicrm-core/pull/12440))**
90 This change makes it so one can dynamically populate a custom field of type
91 select using hooks without using an optiongroup.
93 - **Reduce config required to use Redis.
94 ([12546](https://github.com/civicrm/civicrm-core/pull/12546))**
96 This change makes it so if using Redis, Sysadmins only have to specify the port
97 if not using the standard port 6379.
99 - **Update navigation menu items to use FontAwesome
100 ([12541](https://github.com/civicrm/civicrm-core/pull/12541) and
101 [223](https://github.com/civicrm/civicrm-packages/pull/223))**
103 Updates the menu "caret" (triangles) to use FontAwesome instead of
104 an image file. This is a performance improvement.
106 - **Link to option group page from option group menu item
107 ([12540](https://github.com/civicrm/civicrm-core/pull/12540))**
109 This change adds a link to the option group page from the option group menu
110 item to make it easier to access the "Option Groups" page.
112 - **[dev/core#259](https://lab.civicrm.org/dev/core/issues/259) OptionGroup
113 Admin UI workflow improvements
114 ([12473](https://github.com/civicrm/civicrm-core/pull/12473))**
116 This change improves the Option Group Administration workflow by adding
117 options to edit group settings, displaying a Reserved column on the option
118 group settings, not allowing users to change the data type on reserved option
119 groups, when a user edits an option group redirecting them to the option
120 groups list instead of the default admin page.
122 - **Icons in colored boxes for relationship permissions
123 ([12526](https://github.com/civicrm/civicrm-core/pull/12526))**
125 This change makes it so that on the Relationship tab for a contact permissioned
126 relationships are denoted by icons in squares. Specifically, view permissions
127 appear as a green box with an eye icon and edit permissions as a blue box with
128 a pencil icon. Before this change relationship permissions were denoted with
129 an asterisk and view permissions with an eye icon.
131 - **[dev/accessibility#3](https://lab.civicrm.org/dev/accessibility/issues/3)
132 Add aria-label (and label?) to form elements missing them
133 ([12207](https://github.com/civicrm/civicrm-core/pull/12207) and
134 [12373](https://github.com/civicrm/civicrm-core/pull/12373)) (preliminary work)**
136 Advances work to to use accessible labels on all pages/forms specifically on
137 the Contribution form and the Contact Edit Form.
139 - **[dev/core#233](https://lab.civicrm.org/dev/core/issues/233) Expose
140 information about where a contact has been merged to
141 ([12489](https://github.com/civicrm/civicrm-core/pull/12489))**
143 This change makes it so that if a contact has been merged and is still in the
144 trash next to the contacts name is text explaining which ontact the contact
145 has been merged to. Additionally this change makes it so one can access
146 information on where a contact was merged from/to via the api.
148 - **[dev/core#34](https://lab.civicrm.org/dev/core/issues/34) Split edit/view
149 access on permissioned relationships
150 ([12487](https://github.com/civicrm/civicrm-core/pull/12487) and
151 [12415](https://github.com/civicrm/civicrm-core/pull/12415))**
153 This change makes it so that permissioned relationships can be view only,
154 before this change permissioned relationships were view AND edit. Now one can
155 permission a relationship as view only or view and edit. This change also adds
156 a title to the icon tags that specify if a user has view or edit
159 - **BAO_Navigation: Respect domain_id param
160 ([12476](https://github.com/civicrm/civicrm-core/pull/12476))**
162 This change makes it so that when creating or updating a navigation menu item
163 one can set the domain_id.
165 - **[dev/core#93](https://lab.civicrm.org/dev/core/issues/93) Update
166 CRM_Utils_Rule::mysqlOrderBy() to accommodate more than 2 joins
167 ([12456](https://github.com/civicrm/civicrm-core/pull/12456))**
169 This change makes it so that API users can do more than two joins.
171 - **[dev/core#176](https://lab.civicrm.org/dev/core/issues/176) Odd / Even
172 street number sort column missing from Reports
173 ([12422](https://github.com/civicrm/civicrm-core/pull/12422))**
175 This change adds a Odd/Even street number sort column to reports.
179 - **[CRM-21768](https://issues.civicrm.org/jira/browse/CRM-21768) NOFOLLOW
180 Trackable links in public online view of mailings
181 ([12561](https://github.com/civicrm/civicrm-core/pull/12561))**
183 This change adds the nofollow tag to the trackable URLs in the public view of
184 mailings to prevent the links from being indexed by google.
186 - **[CRM-21574](https://issues.civicrm.org/jira/browse/CRM-21574) Allow to
187 disable sending of email from source contact for tell a friend on pcp
188 ([12475](https://github.com/civicrm/civicrm-core/pull/12475))**
190 When sending an email using the "Tell a Friend" functionality for personal
191 campaign pages this change makes it so you can choose whether the email should
192 come from the default email for the organization OR the contact IDs email
193 address. Before this change the emails would always go out from the contact
194 which can break SPF/DMARC and lead to bounced/failed email delivery.
196 - **[CRM-20845](https://issues.civicrm.org/jira/browse/CRM-20845) create
197 alterMailingRecipients hook
198 ([10673](https://github.com/civicrm/civicrm-core/pull/10673))**
200 This change creates a hook to alter the mailing recipients after they have
201 been constructed but before the mailing is sent.
203 - **[CRM-21425](https://issues.civicrm.org/jira/browse/CRM-21425) Make 'Inbound
204 E-mail' Activities Editable
205 ([12445](https://github.com/civicrm/civicrm-core/pull/12445))**
207 Before this change no one had permission to edit activities of type "Inbound
208 Email", this change adds two new permissions 'edit inbound email basic
209 information' and 'edit inbound email basic information and content' users with
210 these permissions can edit activities of type "Inbound Email".
214 - **[dev/core#111](https://lab.civicrm.org/dev/core/issues/111) Support Custom
215 Data for MembershipType entity
216 ([12439](https://github.com/civicrm/civicrm-core/pull/12439))**
218 This change makes it so that one can view/edit custom data on the
223 - **[dev/core#219](https://lab.civicrm.org/dev/core/issues/219)
224 Improve consistency displaying "Test Transactions"
225 ([12385](https://github.com/civicrm/civicrm-core/pull/12385))**
227 This change makes it so that when you are viewing a test membership help text
228 appears at the top stating that the membership is a test.
230 - **Expose UI support for custom fields on financial types
231 ([12501](https://github.com/civicrm/civicrm-core/pull/12501))**
233 This change makes a user interface for custom fields on financial types.
235 - **[dev/financial#28](https://lab.civicrm.org/dev/financial/issues/28)
236 Financial Account cannot be change to non deductible
237 ([12500](https://github.com/civicrm/civicrm-core/pull/12500))**
239 This change makes it so that a Financial Account can be changed from
240 deductible to non-deductible.
242 - **[dev/core#241](https://lab.civicrm.org/dev/core/issues/241) Fix Manage
243 Premiums UI ([12436](https://github.com/civicrm/civicrm-core/pull/12436))**
245 This change makes it so that on the Manage Premiums Form Financial Type is
246 displayed properly, Money is formatted properly and the Cost field is
249 ## <a name="bugs"></a>Bugs resolved
253 - **[dev/core/#273](https://lab.civicrm.org/dev/core/issues/273) "Recipient
254 phone number is invalid or recipient does not want to receive SMS" error and
255 Contacts with DoNotSms preference failing to filter out during Mass Sms in 5.x
256 ([12654](https://github.com/civicrm/civicrm-core/pull/12654) and
257 [12634](https://github.com/civicrm/civicrm-core/pull/12634))**
259 This change fixes a bug where DoNotSms preference was not being respected when
260 sending Mass Sms messages.
262 - **[dev/core#256](https://lab.civicrm.org/dev/core/issues/256) - Wrong A/B test
263 recipient assignment when reaching 2^31 recipients overall
264 ([12465](https://github.com/civicrm/civicrm-core/pull/12465))**
266 This change fixes a bug where when submitting an A/B mailing to a big enough
267 group (2^31) the whole target group would receive Version A, so that 50% of
268 the sample group receives version A, the other half version B, and the rest is
269 assigned to Final mailing.
271 - **CiviMail: Fix logic for handling SMTP socket errors, temporary failures and
273 ([11838](https://github.com/civicrm/civicrm-core/pull/11838))**
275 Fixes support for sending mail directly to AWS SES via SMTP by detecting
276 additional temporary failure modes.
278 - **[dev/mail#15](https://lab.civicrm.org/dev/mail/issues/15) Extraneous space
279 in From address causes on-hold set on all recipients
280 ([12346](https://github.com/civicrm/civicrm-core/pull/12346))**
282 This change fixes a bug where if there were extraneous spaces in the From
283 address for a CiviMail mailing then no emails were sent and all recipients
284 were marked as On-Hold so that the extraneous space is stripped out and the
285 mailing goes out successfully.
289 - **Only auto-renew membership when contribution status is completed
290 ([12315](https://github.com/civicrm/civicrm-core/pull/12315))**
292 This change makes it so that Membership will only auto-renew when the
293 contribution is in state "Completed".
297 - **[dev/core#289](https://lab.civicrm.org/dev/core/issues/289) CiviCase
298 Dashboard link to edit an activity status broken
299 ([12607](https://github.com/civicrm/civicrm-core/pull/12607))**
301 This change fixes a bug on the CiviCase dashboard where when a user clicked
302 the pencil to edit an activity CiviCRM would throw a 'required params missing'
303 error and crash so that one can edit a case from the CiviCase dashboard by
306 - **[dev/core#278](https://lab.civicrm.org/dev/core/issues/278) DB syntax error
307 when try to search deleted cases
308 ([12560](https://github.com/civicrm/civicrm-core/pull/12560))**
310 This change fixes a DB syntax error that was being thrown whens searching
313 - **[dev/core#218](https://lab.civicrm.org/dev/core/issues/218) On Case Type
314 listing page, for reserved ones the, 'More' link don't show any options
315 ([12384](https://github.com/civicrm/civicrm-core/pull/12384))**
317 Fixes a bug where on the Case Types Listing page the 'More' link would not
318 show any options for reserved case types.
322 - **[CRM-21104](https://issues.civicrm.org/jira/browse/CRM-21104) CIVICRM-410
323 CiviCRM Contribution pages which have no Profile associated with them do not
324 include a ReCaptcha and as a result are prime targets for credit card fraud.
325 ([11197](https://github.com/civicrm/civicrm-core/pull/11197))**
327 This change makes it so that ReCaptcha is shown on all Contribution pages that
328 use a payment processor to process online payments. Before this change
329 ReCaptcha only was shown on contribution pages that used profiles.
331 - **[dev/core#277](https://lab.civicrm.org/dev/core/issues/277) Recurring
332 contribution tab shouldn't count test transactions
333 ([12610](https://github.com/civicrm/civicrm-core/pull/12610) and
334 [12553](https://github.com/civicrm/civicrm-core/pull/12553))**
336 This change makes it so that the Recurring Contributions tab count only counts
337 the 'Active Recurring Contributions' (does not count 'Inactive Recurring
338 Contributions') and sorts the Recurring Contributions by start date starting
341 - **[dev/core#242](https://lab.civicrm.org/dev/core/issues/242) Fix display of
342 premiums on contribution pages
343 ([12437](https://github.com/civicrm/civicrm-core/pull/12437))**
345 This change fixes a bug where premium products without financial types
346 were not being displayed on contribution pages so that premium products are displayed on
347 contribution pages regardless of whether they have a financial type.
349 - **[dev/financial#27](https://lab.civicrm.org/dev/financial/issues/27) Paypal
350 recurring IPNs don't work under some circumstances
351 ([12387](https://github.com/civicrm/civicrm-core/pull/12387))**
353 This change fixes a bug where IPNs for recurring donations made using PayPal
354 Standard did not work if the business emails did not match.
356 - **[dev/core#188](https://lab.civicrm.org/dev/core/issues/188) Fix Floating
357 Point Precision Comparison Exception on Order Creation
358 ([12352](https://github.com/civicrm/civicrm-core/pull/12352))**
360 This change fixes a bug where sometimes contributions would fail because the
361 total amount and the total of the line items would not be exactly equal
362 because of floating point precision issues.
364 - **PriceField: show pre/post help if not empty, not if isset.
365 ([12458](https://github.com/civicrm/civicrm-core/pull/12458))**
367 Fixes a bug for multilingual mode where radio options in price sets with empty
368 pre/post help were displaying pre/post help as ':' so that no ':' are shown.
372 - **Fix + Add test for exporting location types with changed names
373 ([12671](https://github.com/civicrm/civicrm-core/pull/12671))**
375 This change fixes a bug where if a location types name did not exactly match
376 its value it was not exporting properly so that the label exports properly.
378 - **Event Info: show waitinglist statusline only when registration is open
379 ([11949](https://github.com/civicrm/civicrm-core/pull/11949))**
381 This change makes it so when on an Event Info page, if the event is closed, no
382 other notices about registration are shown.
384 - **[dev/core#255](https://lab.civicrm.org/dev/core/issues/255) Changes to
385 copied event location reflects in original event location
386 ([12459](https://github.com/civicrm/civicrm-core/pull/12459))**
388 Fixes a bug where if one copied an event and then changed the location, the
389 location would also be changed on the original event so that one can change
390 the event on the copy without it having an effect on the original.
392 - **[dev/core#239](https://lab.civicrm.org/dev/core/issues/239) Huge title
393 dialog box on hovering form element on Event's configuration backend form
394 ([12430](https://github.com/civicrm/civicrm-core/pull/12430))**
396 This change improves the user interface on the Event Configuration Form by
397 making the dialog boxes when hovering on form elements cleaner.
401 - **Fix for issue editing custom fields with option groups after #12423
402 ([12718](https://github.com/civicrm/civicrm-core/pull/12718))**
404 This change fixes a bug where one could not save changes to a custom field
405 that uses option groups so that one can save changes to a custom field with
408 - **Update civicrm_generated mysql file following changes to custom mysql…
409 ([12719](https://github.com/civicrm/civicrm-core/pull/12719))**
411 This change ensures that some default custom groups are not reserved.
413 - **[dev/core#293](https://lab.civicrm.org/dev/core/issues/293) Error log is
414 filled with geocoding configuration errors when no provider is set
415 ([12600](https://github.com/civicrm/civicrm-core/pull/12600))**
417 This change fixes a bug where if no geocoding provider is set on a site an
418 error was thrown to the error log so that no error is thrown.
420 - **[dev/core#232](https://lab.civicrm.org/dev/core/issues/232) Contact types
421 with double hyphens in 'name' field : searches not returning any contactsh
422 ([12416](https://github.com/civicrm/civicrm-core/pull/12416))**
424 This change fixes a bug where when searching for contacts using a contact sub type
425 no results were returned so that contacts of that sub type are returned.
427 - **[dev/core#210](https://lab.civicrm.org/dev/core/issues/210) Regex filter
428 broken in Search Builder
429 ([12364](https://github.com/civicrm/civicrm-core/pull/12364))**
431 This change fixes the Regex filter in the Search Builder so that it returns
432 more accurate results.
434 - **Theme layer Fix search for Shoreditch compatibility
435 ([12536](https://github.com/civicrm/civicrm-core/pull/12536))**
437 This change fixes the ui on the search page to show the table headers for
438 sites using the shoreditch theme.
440 - **Shoreditch support: Fix following change in core that resulted in visual
441 regression in shoreditch in advanced search
442 ([12524](https://github.com/civicrm/civicrm-core/pull/12524))**
444 This change improves the layout of the advanced search page for users using
447 - **[dev/core#150](https://lab.civicrm.org/dev/core/issues/150) Chain select for
448 country/state in Search Builder does not stay within OR groupings
449 ([12230](https://github.com/civicrm/civicrm-core/pull/12230))**
451 This change fixes a bug in search builder where if one Choose a Country in the
452 "Include contacts where" section that would also filter the available state
453 options in the "Also include contacts where" section.
455 - **[dev/core#230](https://lab.civicrm.org/dev/core/issues/230) Saved Search :
456 Set Mapping id to null on mapping delete
457 ([12486](https://github.com/civicrm/civicrm-core/pull/12486))**
459 This change fixes a db error when deleting a saved search so that one can
460 delete a saved search without getting a database error.
462 - **Fix false negatives in checkResourceUrl()
463 ([12460](https://github.com/civicrm/civicrm-core/pull/12460))**
465 This change fixes a bug where an "The Resource URL is not set correctly.
466 Please set the CiviCRM Resource URL." error was being thrown when the CiviCRM
467 Resource URL was set to "[civicrm.root]/" so that no error is thrown when
468 the CiviCRM Resource URL is set.
470 - **Fix activity report to bring it under standardised report testing
471 ([12453](https://github.com/civicrm/civicrm-core/pull/12453))**
473 This change makes it possible to write unit tests for the Activity Report.
475 - **[dev/core#155](https://lab.civicrm.org/dev/core/issues/155) Improvements and
476 bugfixes to Option Groups UI
477 ([12423](https://github.com/civicrm/civicrm-core/pull/12423)) (preliminary work)**
479 This change makes it so that Option Groups that are created thru the user
480 interface can be used with custom fields.
482 - **Disable inline-edit of multi-record custom fields in profiles
483 ([12312](https://github.com/civicrm/civicrm-core/pull/12312))**
485 This change makes it so that one cannot inline-edit multi-record custom fields
486 in profiles. Before this change there was a button to edit but clicking it
487 would throw a javascript error.
489 - **Make domain_id optional in membership_type api.
490 ([12461](https://github.com/civicrm/civicrm-core/pull/12461))**
492 This change makes the domain_id a optional parameter in the membership_type
493 api, if it is not sent it is set to be the current domain.
495 - **[dev/core#141](https://lab.civicrm.org/dev/core/issues/141) Custom groups
496 with different names but same title would not be saved
497 ([12464](https://github.com/civicrm/civicrm-core/pull/12464))**
499 This change makes it so you can have custom groups with the same title so long
500 as they have different names.
502 - **CustomValue gettree api - More accurate permission check
503 ([12449](https://github.com/civicrm/civicrm-core/pull/12449))**
505 This change makes it so that a user can call the gettree api from ajax if they
506 have the permission to view the main object. Prior to this change the user had
507 to have the permission 'administer CiviCRM' to access the gettree api from
510 - **[dev/core#221](https://lab.civicrm.org/dev/core/issues/221) Inappropriate
511 warning on preview page of empty custom data set
512 ([12392](https://github.com/civicrm/civicrm-core/pull/12392))**
514 Removes an Undefined Offset error being thrown when a new custom data set is
515 created and then previewed.
517 - **[dev/core#228](https://lab.civicrm.org/dev/core/issues/228) Option group
519 ([12410](https://github.com/civicrm/civicrm-core/pull/12410))**
521 Fixes a bug where Option Groups being being created or updated thru the api
522 without the is_active parameter set were being set as not active.
524 - **Implement CRM_Utils_SQL_Delete
525 ([12441](https://github.com/civicrm/civicrm-core/pull/12441))**
527 This change makes CRM_Utils_SQL_Delete a query-building utility and has it
528 extend a common base-class as CRM_Utils_SQL_Select.
530 - **[dev/core#174](https://lab.civicrm.org/dev/core/issues/174) Consistently use
531 swappable cache interfaces
532 ([12427](https://github.com/civicrm/civicrm-core/pull/12427)) (preliminary
535 This patch makes tests more reliable by refining the way SqlGroup handles
536 trivially short TTLs.
538 - **[dev/core#212](https://lab.civicrm.org/dev/core/issues/212) Contribution
539 Details report fails when "Is not one of" condition is used for Groups field
540 ([12406](https://github.com/civicrm/civicrm-core/pull/12406))**
542 Fixes a DB error when contribution detail report is filtered by the "is not
543 one of" Group operator.
545 - **[dev/core#292](https://lab.civicrm.org/dev/core/issues/292) Search builder
546 stops working after 5.3.1 (due accents on custom set fields titles)
547 ([225](https://github.com/civicrm/civicrm-packages/pull/225))**
549 Fixes a bug where search builder would choke on accented characters in custom
550 set field titles so that Search builder can handle accented characters in
551 custom set field titles.
553 - **[CRM-21754](https://issues.civicrm.org/jira/browse/CRM-21754) Duplicate
554 rows in Activity Details report when address fields are displayed
555 ([11660](https://github.com/civicrm/civicrm-core/pull/11660))**
557 Fixes a bug where the Activity Details report would show duplicate rows when
558 activity contacts had different addresses so that only one row is shown per
561 ### Backdrop Integration
563 - **[dev/core#243](https://lab.civicrm.org/dev/core/issues/243) Backdrop
564 authentication function missing in kcfinder package.
565 ([216](https://github.com/civicrm/civicrm-packages/pull/216))**
567 Fixes Kcfinder package authentication for Backdrop users.
569 ### WordPress Integration
571 - **[CRM-21812](https://issues.civicrm.org/jira/browse/CRM-21812) WordPress
572 install variable causes conflict with some WP plugins
573 ([125](https://github.com/civicrm/civicrm-wordpress/pull/125))**
575 This change makes it so civicrm is compatible with the wp-cli-login-server
578 ### Drupal Integration
580 - **Allow Drupal 8 vendor folder outside webroot
581 ([12499](https://github.com/civicrm/civicrm-core/pull/12499))**
583 This change makes it so that civicrm Drupal 8 integrations can store vendor
584 folders outside the webroot.
586 - **Fix Views custom field handler not displaying select value labels when
587 fields share the same label.
588 ([532](https://github.com/civicrm/civicrm-drupal/pull/532))**
590 Fixes a bug where views custom field handler was not displaying select value
591 labels when more than one field had the same label.
593 ## <a name="misc"></a>Miscellany
595 - **Simplify input params on OptionValue::addOptionValue
596 ([12414](https://github.com/civicrm/civicrm-core/pull/12414))**
598 - **Enable syntaxConformance on entities that now succeed
599 ([12412](https://github.com/civicrm/civicrm-core/pull/12412))**
601 - **CRM_Core_BAO_PrevNextCache - Remove unused buildSelectedContactPager()
602 ([12418](https://github.com/civicrm/civicrm-core/pull/12418))**
604 - **NFC - Deprecate duplicate function
605 ([12602](https://github.com/civicrm/civicrm-core/pull/12602))**
607 - **[NFC] Update comment link
608 ([12429](https://github.com/civicrm/civicrm-core/pull/12429))**
610 - **[NFC] Export - don't pass arrays as reference when they are not changed
611 ([12596](https://github.com/civicrm/civicrm-core/pull/12596))**
613 - **(NFC) Update readme to link to GitLab instead of JIRA
614 ([12578](https://github.com/civicrm/civicrm-core/pull/12578))**
616 - **(NFC) Remove deprecated recursive array utils
617 ([12539](https://github.com/civicrm/civicrm-core/pull/12539))**
619 - **(NFC) Deprecate redundant array util function
620 ([12529](https://github.com/civicrm/civicrm-core/pull/12529))**
622 - **[NFC] Comment fixes
623 ([12450](https://github.com/civicrm/civicrm-core/pull/12450))**
625 - **(NFC) Remove deprecated function use
626 ([221](https://github.com/civicrm/civicrm-packages/pull/221))**
629 ([219](https://github.com/civicrm/civicrm-packages/pull/219))**
631 - **(NFC) Ignore generated karma.cv.js file
632 ([12462](https://github.com/civicrm/civicrm-core/pull/12462))**
634 - **(NFC) Update comment on membership type domain_id API Test
635 ([12477](https://github.com/civicrm/civicrm-core/pull/12477))**
637 - **(NFC) Regenerate OptionGroup DAO file
638 ([12478](https://github.com/civicrm/civicrm-core/pull/12478))**
640 - **NFC cleanup to financial classes
641 ([12482](https://github.com/civicrm/civicrm-core/pull/12482))**
643 - **Stdise references to BAO_Query->_fields [nfc]
644 ([12585](https://github.com/civicrm/civicrm-core/pull/12585))**
646 - **Test fix for intermittant error
647 ([12673](https://github.com/civicrm/civicrm-core/pull/12673))**
649 - **Test fix, update activity report adds a this.month filter by default,
650 accomodate ([12616](https://github.com/civicrm/civicrm-core/pull/12616))**
652 - **Customvalue ID is ignored
653 ([12606](https://github.com/civicrm/civicrm-core/pull/12606))**
655 - **Towards using EntityForm.tpl for Membership type & enabling custom data
656 ([12591](https://github.com/civicrm/civicrm-core/pull/12591))**
658 - **Export Add unit test + minor refactor covering specifiable payment output
659 fields for participant export.
660 ([12535](https://github.com/civicrm/civicrm-core/pull/12535))**
663 ([12592](https://github.com/civicrm/civicrm-core/pull/12592))**
665 - **5.4 ([12428](https://github.com/civicrm/civicrm-core/pull/12428))**
667 - **5.4 ([12448](https://github.com/civicrm/civicrm-core/pull/12448))**
670 ([12508](https://github.com/civicrm/civicrm-core/pull/12508))**
672 - **Merge 5.4 to master
673 ([12511](https://github.com/civicrm/civicrm-core/pull/12511))**
675 - **5.4 ([12520](https://github.com/civicrm/civicrm-core/pull/12520))**
677 - **Add 5.3.2 release notes (#12570)
678 ([12571](https://github.com/civicrm/civicrm-core/pull/12571))**
680 - **5.4 ([12569](https://github.com/civicrm/civicrm-core/pull/12569))**
683 ([12515](https://github.com/civicrm/civicrm-core/pull/12515))**
686 ([12555](https://github.com/civicrm/civicrm-core/pull/12555))**
688 - **5.4 ([12549](https://github.com/civicrm/civicrm-core/pull/12549))**
691 ([12534](https://github.com/civicrm/civicrm-core/pull/12534))**
693 - **Export clean up sql columns
694 ([12577](https://github.com/civicrm/civicrm-core/pull/12577))**
696 - **crmRouteBinder - Don't convert arrays to objects
697 ([12530](https://github.com/civicrm/civicrm-core/pull/12530))**
699 - **Added code to throw exception on getvalue api call
700 ([12573](https://github.com/civicrm/civicrm-core/pull/12573))**
702 - **[dev/financial#24](https://lab.civicrm.org/dev/financial/issues/24) Link
703 payment method to financial account when created using api
704 ([12388](https://github.com/civicrm/civicrm-core/pull/12388))**
706 - **Move relationship return properties to the processor class to fix leakage
708 ([12521](https://github.com/civicrm/civicrm-core/pull/12521))**
710 - **Extract code for getting additional return properties, test
711 ([12505](https://github.com/civicrm/civicrm-core/pull/12505))**
713 - **Fix signature on BAO_Product::add to make ids optional
714 ([12523](https://github.com/civicrm/civicrm-core/pull/12523))**
716 - **Export : Add a lot of unit tests. Fix an enotice
717 ([12518](https://github.com/civicrm/civicrm-core/pull/12518))**
719 - **Fix regression on case export from recent export fix
720 ([12517](https://github.com/civicrm/civicrm-core/pull/12517))**
722 - **Remove LOWER from street_address search, rely on mysql to handle.
723 ([12503](https://github.com/civicrm/civicrm-core/pull/12503))**
725 - **Respect '0' as a default when generating DAOs
726 ([12483](https://github.com/civicrm/civicrm-core/pull/12483))**
728 - **Export cleanup Extract bulk of the transformation for each field to its own
729 function ([12469](https://github.com/civicrm/civicrm-core/pull/12469))**
731 - **Fix enotice in test
732 ([12507](https://github.com/civicrm/civicrm-core/pull/12507))**
734 - **Test fix, use separate emails so distinct doesn't meld them
735 ([12490](https://github.com/civicrm/civicrm-core/pull/12490))**
737 - **Export cleanup - pass processor object rather than the query object
738 ([12485](https://github.com/civicrm/civicrm-core/pull/12485))**
740 - **Minor refactor preparatory to function extraction
741 ([12468](https://github.com/civicrm/civicrm-core/pull/12468))**
743 - **Cleanup redundant array functions
744 ([12452](https://github.com/civicrm/civicrm-core/pull/12452))**
746 - **Export code tidy up Use queryFields rather than query. Look to stop passing
747 around query. ([12484](https://github.com/civicrm/civicrm-core/pull/12484))**
749 - **Export class code cleanup Start building export processor class.
750 ([12479](https://github.com/civicrm/civicrm-core/pull/12479))**
752 - **Rename CRM_Contribute_BAO_ManagePremiums to CRM_Contribute_BAO_Product and
753 deprecate CRM_Contribute_BAO_ManagePremiums
754 ([12474](https://github.com/civicrm/civicrm-core/pull/12474))**
756 - **Remove unused variables & comment cleanup
757 ([12472](https://github.com/civicrm/civicrm-core/pull/12472))**
759 - **Non functional changes towards shared functions in Core_Form_Task
760 ([12320](https://github.com/civicrm/civicrm-core/pull/12320))**
762 - **Export class code readability - Reduce passing of variable, define on class
763 ([12290](https://github.com/civicrm/civicrm-core/pull/12290))**
765 - **Deprecate array on ManagePremiums
766 ([12451](https://github.com/civicrm/civicrm-core/pull/12451))**
768 - **Remove old deprecated crmeditable.tpl
769 ([12442](https://github.com/civicrm/civicrm-core/pull/12442))**
771 - **Fix potential undefined array index
772 ([12443](https://github.com/civicrm/civicrm-core/pull/12443))**
776 - **Update release-notes and version for 5.4.1 ([12655](https://github.com/civicrm/civicrm-core/pull/12655))**
778 - **Fix quirks in upgrader UI ([12675](https://github.com/civicrm/civicrm-core/pull/12675))**
780 ## <a name="credits"></a>Credits
782 This release was developed by the following code authors:
784 AGH Strategies - Andrew Hunt; Agileware - Alok Patel; Australian Greens - Seamus Lee; Caltha - Tomasz Pietrzkowski; Chris Burgess; CiviCoop - Jaap Jansma; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Sunil Pawar, Yashodha Chaku; CompuCorp - Camilo Rodriguez, Mukesh Ram; Coop SymbioTIC - Mathieu Lutfy; Electronic Frontier Foundation - Mark Burdett; eQuality Technology - Greg Rundlett; Freeform Solutions - Herb van den Dool; Fuzion - Jitendra Purohit; JMA Consulting - Monish Deb; John Kingsnorth; Left Join Labs - Sean Madsen; madhavimalgaonkar; Megaphone Technology Consulting - Jon Goldberg; MJW Consulting - Matthew Wire; Oxfam Germany - Thomas Schüttler; Pradeep Nayak; Progressive Technology Project - Jamie McClelland; Richard van Oosterhout; Romain Thouvenin; Squiffle Consulting - Aidan Saunders; Tadpole Collective - Kevin Cristiano; Third Sector Design - Michael McAndrew; wannesderoy; Wikimedia Foundation - Eileen McNaughton
786 Most authors also reviewed code for this release; in addition, the following
787 reviewers contributed their comments:
789 AGH Strategies - Alice Frumin, Andrew Hunt; Agileware - Agileware Team; Andrew Cormick-Dockery; Australian Greens - Seamus Lee; bluegreenbay; bmango; CEDC - Laryn Kragt Bakker; chamilwijesooriya; Chris Burgess; Christian Wach; Circle Interactive - Dave Jenkins; civibot[bot]; civicrm-builder; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Yashodha Chaku; CompuCorp - Camilo Rodriguez; Coop SymbioTIC - Mathieu Lutfy; Electronic Frontier Foundation - Mark Burdett; Francesc Bassas i Bullich; Freeform Solutions - Herb van den Dool; Fuzion - Peter Davis; Greenleaf Advancement - Karen Stevenson; JMA Consulting - Monish Deb; jmcheung; John Kingsnorth; laurynnlowe; Lemniscus - Noah Miller; Lighthouse Design and Consulting - Brian Shaughnessy; marsh-circle; Megaphone Technology Consulting - Jon Goldberg; MJW Consulting - Matthew Wire; myDropWizard - David Snopek; Oxfam Germany - Thomas Schüttler; Pradeep Nayak; Progressive Technology Project - Jamie McClelland; Richard van Oosterhout; Semper IT - Karin Gerritsen; Squiffle Consulting - Aidan Saunders; stesi561; Tadpole Collective - Kevin Cristiano; tanyabouman; Third Sector Design - Michael McAndrew; wannesderoy; Wikimedia Foundation - Eileen McNaughton
791 ## <a name="feedback"></a>Feedback
793 These release notes are edited by Alice Frumin and Andrew Hunt. If you'd like to provide
794 feedback on them, please log in to https://chat.civicrm.org/civicrm and contact