release-notes/5.4.0.md

   1 # CiviCRM 5.4.0
   2
   3 Released August 1, 2018
   4
   5 - **[Synopsis](#synopsis)**
   6 - **[Features](#features)**
   7 - **[Bugs resolved](#bugs)**
   8 - **[Miscellany](#misc)**
   9 - **[Credits](#credits)**
  10 - **[Feedback](#feedback)**
  11
  12 ## <a name="synopsis"></a>Synopsis
  13
  14 | *Does this version...?*                                         |         |
  15 |:--------------------------------------------------------------- |:-------:|
  16 | Fix security vulnerabilities?                                   |   no    |
  17 | **Change the database schema?**                                 | **yes** |
  18 | **Alter the API?**                                              | **yes** |
  19 | **Require attention to configuration options?**                 | **yes** |
  20 | **Fix problems installing or upgrading to a previous version?** | **yes** |
  21 | **Introduce features?**                                         | **yes** |
  22 | **Fix bugs?**                                                   | **yes** |
  23
  24 ## <a name="features"></a>Features
  25
  26 ### Core CiviCRM
  27
  28 - **[CRM-20430](https://issues.civicrm.org/jira/browse/CRM-20430) A permission
  29   'save Report Criteria'
  30   ([12107](https://github.com/civicrm/civicrm-core/pull/12107))**
  31
  32   Permission to edit the criteria for saved reports is now separate from the
  33   permission to access and preview modifications of report criteria.  This will
  34   prevent non-privileged users from modifying the criteria of an organization's
  35   standard reports.  However when upgrading, site administrators will need to
  36   grant the Save Report Criteria permission to roles that need that capability.
  37
  38 - **[dev/core#174](https://lab.civicrm.org/dev/core/issues/174) Consistently use
  39   swappable cache interfaces
  40   ([12321](https://github.com/civicrm/civicrm-core/pull/12321),
  41   [12322](https://github.com/civicrm/civicrm-core/pull/12322),
  42   [12323](https://github.com/civicrm/civicrm-core/pull/12323),
  43   [12330](https://github.com/civicrm/civicrm-core/pull/12330),
  44   [12331](https://github.com/civicrm/civicrm-core/pull/12331),
  45   [12336](https://github.com/civicrm/civicrm-core/pull/12336),
  46   [12342](https://github.com/civicrm/civicrm-core/pull/12342),
  47   [12348](https://github.com/civicrm/civicrm-core/pull/12348),
  48   [12354](https://github.com/civicrm/civicrm-core/pull/12354),
  49   [12362](https://github.com/civicrm/civicrm-core/pull/12362),
  50   [12368](https://github.com/civicrm/civicrm-core/pull/12368),
  51   [12376](https://github.com/civicrm/civicrm-core/pull/12376),
  52   [12378](https://github.com/civicrm/civicrm-core/pull/12378),
  53   [12379](https://github.com/civicrm/civicrm-core/pull/12379),
  54   [12380](https://github.com/civicrm/civicrm-core/pull/12380),
  55   [12381](https://github.com/civicrm/civicrm-core/pull/12381),
  56   [12389](https://github.com/civicrm/civicrm-core/pull/12389), and
  57   [215](https://github.com/civicrm/civicrm-packages/pull/215))**
  58
  59   Sites using Redis or Memcache for caching will now use those facilities
  60   exclusively rather than retaining the `civicrm_cache` table as a backstop.
  61   This improves performance for these sites, especially those using multiple
  62   MySQL servers.
  63
  64 - **[CRM-21574](https://issues.civicrm.org/jira/browse/CRM-21574) Allow to
  65   disable sending of email from source contact for tell a friend on pcp
  66   ([12355](https://github.com/civicrm/civicrm-core/pull/12355)) (preliminary
  67   work)**
  68
  69   Emails from the "tell a friend" feature are sent as if they are from the
  70   donor's address.  This can cause delivery failures as the site may not be a
  71   valid source for the donor's email domain.  Changes here are preliminary
  72   cleanup.
  73
  74 - **[dev/core#32](https://lab.civicrm.org/dev/core/issues/32) Add option to
  75   disable cancel button on a profile form
  76   ([11883](https://github.com/civicrm/civicrm-core/pull/11883))**
  77
  78   The Cancel button is now optional on profile forms.
  79
  80 - **[CRM-21392](https://issues.civicrm.org/jira/browse/CRM-21392) Allow viewing
  81   groups/smartgroups as as other entities (eg. memberships, events)
  82   ([11241](https://github.com/civicrm/civicrm-core/pull/11241))**
  83
  84   The Find Groups page now has a similar "View Results As" feature as the
  85   Advanced Search: you can choose to view memberships, events, activities, etc.
  86   of group subscribers rather than the contacts themselves.
  87
  88 - **[CRM-21622](https://issues.civicrm.org/jira/browse/CRM-21622) Make the Add
  89   Parent Groups on Group Settings be a multiselect
  90   ([11481](https://github.com/civicrm/civicrm-core/pull/11481))**
  91
  92   The New Group form now allows you to set multiple parent groups for a single
  93   group.
  94
  95 - **[CRM-21460](https://issues.civicrm.org/jira/browse/CRM-21460) Programmatic
  96   access to job execution status
  97   ([11337](https://github.com/civicrm/civicrm-core/pull/11337))**
  98
  99   Extension developers can implement two new hooks, `hook_civicrm_preJob` and
 100   `hook_civicrm_postJob`, which are invoked before and after executing a
 101   scheduled job.
 102
 103 - **Change default for `CIVICRM_CONTAINER_CACHE` to simplify admin/developer
 104   experience ([12426](https://github.com/civicrm/civicrm-core/pull/12426))**
 105
 106 - **[dev/core#223](https://lab.civicrm.org/dev/core/issues/223) Expose prefix
 107   and suffix in reports
 108   ([12394](https://github.com/civicrm/civicrm-core/pull/12394))**
 109
 110   Individuals' prefix and suffix fields are now available as columns and filters
 111   among the contact fields in most reports.
 112
 113 - **[dev/core#101](https://lab.civicrm.org/dev/core/issues/101) Allow further
 114   customization of search form in hooks
 115   ([12078](https://github.com/civicrm/civicrm-core/pull/12078))**
 116
 117   Fields are no longer explicitly included in the search form template since
 118   that makes it hard to add or remove fields.  Instead, the fields are listed in
 119   template variables, and the template iterates over the list to render the
 120   field elements.
 121
 122 - **[dev/core#183](https://lab.civicrm.org/dev/core/issues/183) Temporary tables
 123   should follow consistent naming convention
 124   ([12311](https://github.com/civicrm/civicrm-core/pull/12311)) (partially
 125   completed)**
 126
 127   This moves towards naming temporary tables--both true temporary tables in
 128   MySQL and regular tables created for temporary use--in a consistent manner in
 129   order to help database administrators employ replication policies based upon
 130   table names.
 131
 132 - **[dev/core#144](https://lab.civicrm.org/dev/core/issues/144)
 133   `getCustomFieldID` switch to API, add caching, add full string return option
 134   ([12218](https://github.com/civicrm/civicrm-core/pull/12218) and
 135   [12283](https://github.com/civicrm/civicrm-core/pull/12283))**
 136
 137   The function to retrieve a custom field ID now relies upon APIv3 rather than
 138   an *ad hoc* SQL query.  It also contains an option to return the ID preceded
 139   by `custom_`.  Finally, the function caches the result and attempts to return
 140   the cached value rather than looking it up each time.
 141
 142 - **[dev/core#47](https://lab.civicrm.org/dev/core/issues/47) Add "clone"
 143   functionality to scheduled jobs
 144   ([11945](https://github.com/civicrm/civicrm-core/pull/11945))**
 145
 146   Scheduled jobs can now be copied, including their parameters, both from the
 147   Scheduled Jobs page and through a new `Job.clone` API method.
 148
 149 ### CiviCase
 150
 151 - **[dev/core#107](https://lab.civicrm.org/dev/core/issues/107) After creating a
 152   new case, the assignee for each activity must be selected manually
 153   ([11998](https://github.com/civicrm/civicrm-core/pull/11998))**
 154
 155   You can now select the default assignee for each activity in the standard
 156   timeline for a case type.  This may be defined according to a relationship
 157   with the client, a single specific contact, or the contact who created the
 158   case.
 159
 160 - **CiviCase, added reference of activities from different timelines.
 161   ([12236](https://github.com/civicrm/civicrm-core/pull/12236))**
 162
 163   From an activity on a case timeline, you can now reference any activity
 164   available to the case--not just those on that case timeline.
 165
 166 ### CiviContribute
 167
 168 - **Add support for hidden fields in general (and 'token' specifically) on the
 169   payment form. ([12332](https://github.com/civicrm/civicrm-core/pull/12332)
 170   and [12391](https://github.com/civicrm/civicrm-core/pull/12391))**
 171
 172   A new authorization token field is added to the payment form to support
 173   token-based payment processors.
 174
 175 - **[CRM-21808](https://issues.civicrm.org/jira/browse/CRM-21808) Install custom
 176   group for Contribution or ContributioRecur subtypes based on XML file
 177   ([11726](https://github.com/civicrm/civicrm-core/pull/11726))**
 178
 179   Extensions created custom data sets for contributions can now specify the
 180   custom data to apply only to a single financial type.
 181
 182 - **(dev/core/50) and
 183   [dev/core#195](https://lab.civicrm.org/dev/core/issues/195) Add Separate
 184   Sub-tabs for Contributions and Recurring  Contributions
 185   ([11956](https://github.com/civicrm/civicrm-core/pull/11956) and
 186   [12345](https://github.com/civicrm/civicrm-core/pull/12345))**
 187
 188   The Contributions tab on a contact now contains two sub-tabs--one for single
 189   contributions, and the other for recurring contribution series--instead of
 190   displaying one after the other.
 191
 192 - **[dev/core#96](https://lab.civicrm.org/dev/core/issues/96) Expose source
 193   column in booking report
 194   ([12374](https://github.com/civicrm/civicrm-core/pull/12374))**
 195
 196   The contribution Source field is now available as a column and filter on the
 197   Bookkeeping Transactions report.
 198
 199 - **Use html5 color input for contribution page widget
 200   ([12339](https://github.com/civicrm/civicrm-core/pull/12339))**
 201
 202 ### CiviMail
 203
 204 - **[dev/mail#1](https://lab.civicrm.org/dev/mail/issues/1) Add pause/resume
 205   functionality to civicrm bulk mailing.
 206   ([11803](https://github.com/civicrm/civicrm-core/pull/11803) and
 207   [12284](https://github.com/civicrm/civicrm-core/pull/12284))**
 208
 209   A CiviMail mailing that is scheduled or in progress can now be paused in order
 210   to allow an urgent message to go out first.
 211
 212 - **Add in bootstrap button classes to CiviMail interface
 213   ([12013](https://github.com/civicrm/civicrm-core/pull/12013) and
 214   [12338](https://github.com/civicrm/civicrm-core/pull/12338))**
 215
 216   This allows the interfaces to be themed more easily by Bootstrap-based themes.
 217
 218 ## <a name="bugs"></a>Bugs resolved
 219
 220 ### Core CiviCRM
 221
 222 - **[dev/core#222](https://lab.civicrm.org/dev/core/issues/222) Importing
 223   contacts with dedupe rule does not use the rule
 224   ([12393](https://github.com/civicrm/civicrm-core/pull/12393))**
 225
 226 - **[dev/core#284](https://lab.civicrm.org/dev/core/issues/284) Aggressive cache
 227   clearing significantly increases test time
 228   ([12590](https://github.com/civicrm/civicrm-core/pull/12590)) (partial work)**
 229
 230   Settings, compiled Javascript, extension, and other caches are now only
 231   flushed along with the main CiviCRM cache if an external cache like Redis or
 232   Memcache is in use.
 233
 234 - **[dev/core#279](https://lab.civicrm.org/dev/core/issues/279) When Merging two
 235   contacts, Flip between original and duplicate link not working in WordPress
 236   ([12568](https://github.com/civicrm/civicrm-core/pull/12568))**
 237
 238 - **Handle 'Check for Matching Contact(s)' button with ajax
 239   ([12552](https://github.com/civicrm/civicrm-core/pull/12552))**
 240
 241   This resolves a bug where the "Check for Matching Contact(s)" button would not
 242   work if AJAX Deduping is enabled.
 243
 244 - **[dev/core#131](https://lab.civicrm.org/dev/core/issues/131) Add in missing
 245   UK shire Monmouthshire
 246   ([12538](https://github.com/civicrm/civicrm-core/pull/12538)) (follow-up on
 247   previous work)**
 248
 249   Many individual sites had manually added the county of Monmouthshire in Wales
 250   to the `civicrm_state_province` table, and upgrading to 5.3.0, which added the
 251   missing record, would cause them a database error.
 252
 253 - **[dev/core#258](https://lab.civicrm.org/dev/core/issues/258) Possible
 254   unreleased regression - message template update altered customised template
 255   ([12492](https://github.com/civicrm/civicrm-core/pull/12492))**
 256
 257 - **[dev/core#249](https://lab.civicrm.org/dev/core/issues/249) Contact Export
 258   fails in 5.4 when trying to export using the All radio button
 259   ([12447](https://github.com/civicrm/civicrm-core/pull/12447))**
 260
 261 - **[dev/core#234](https://lab.civicrm.org/dev/core/issues/234) Upgrade Steps in
 262   5.3.alpha1 may not have been run
 263   ([12419](https://github.com/civicrm/civicrm-core/pull/12419),
 264   [12420](https://github.com/civicrm/civicrm-core/pull/12420), and
 265   [12425](https://github.com/civicrm/civicrm-core/pull/12425))**
 266
 267 - **[dev/core#155](https://lab.civicrm.org/dev/core/issues/155) Improvements and
 268   bugfixes to Option Groups UI
 269   ([12233](https://github.com/civicrm/civicrm-core/pull/12233) and
 270   [12411](https://github.com/civicrm/civicrm-core/pull/12411))**
 271
 272   The Option Groups page now displays whether each option group is reserved or
 273   enabled.  In addition, sites using sample data no longer have the sample
 274   custom fields reserved.
 275
 276 - **[CRM-20184](https://issues.civicrm.org/jira/browse/CRM-20184) Some System
 277   Workflow templates still miss {contact.email_greeting}
 278   ([12296](https://github.com/civicrm/civicrm-core/pull/12296))**
 279
 280   This makes receipt templates more consistent in using the contact's email
 281   greeting when sent to individuals.
 282
 283 - **[dev/core#41](https://lab.civicrm.org/dev/core/issues/41) Search Builder:
 284   Not empty with date or integer custom fields gives a sql warning
 285   ([12351](https://github.com/civicrm/civicrm-core/pull/12351) and
 286   [12363](https://github.com/civicrm/civicrm-core/pull/12363))**
 287
 288 - **Make all form tasks inherit from `CRM_Core_Form_Task`
 289   ([12318](https://github.com/civicrm/civicrm-core/pull/12318))**
 290
 291   This addresses some export problems caused by tasks lacking certain properties
 292   because their classes did not extend `CRM_Core_Form_Task`.
 293
 294 - **[dev/core#178](https://lab.civicrm.org/dev/core/issues/178) Redis driver -
 295   Error messages are invisible
 296   ([12303](https://github.com/civicrm/civicrm-core/pull/12303))**
 297
 298   The log now contains error messages passed from Redis.
 299
 300 - **[dev/core#180](https://lab.civicrm.org/dev/core/issues/180) Deleting custom
 301   values and custom_hook parameter `$entity_id` empty
 302   ([12309](https://github.com/civicrm/civicrm-core/pull/12309))**
 303
 304   The ID of the affected entity is now passed to `hook_civicrm_custom` when a
 305   value is deleted from a custom field.
 306
 307 - **Fix access to scheduled reminders for admins without event access
 308   ([11733](https://github.com/civicrm/civicrm-core/pull/11733))**
 309
 310   Users with Administer CiviCRM permission but lacking Manage Events permission
 311   would get an error when trying to create a non-event scheduled reminder.
 312
 313 - **Only treat a request as a get request (and hence use GET) if it starts with
 314   get ([12308](https://github.com/civicrm/civicrm-core/pull/12308))**
 315
 316 - **[dev/core#179](https://lab.civicrm.org/dev/core/issues/179) Redis driver -
 317   Allow anonymous connections
 318   ([12304](https://github.com/civicrm/civicrm-core/pull/12304))**
 319
 320   Redis no longer attempts to authenticate when no password is set, such as on
 321   local development environments.
 322
 323 - **[dev/core#177](https://lab.civicrm.org/dev/core/issues/177) Redis driver -
 324   Reports incorrect value for cache-miss
 325   ([12302](https://github.com/civicrm/civicrm-core/pull/12302))**
 326
 327   When a cache key is undefined, Redis now returns `NULL` rather than `FALSE`.
 328
 329 - **[dev/core#175](https://lab.civicrm.org/dev/core/issues/175) Smart group
 330   involving relationship type filter display incorrect results.
 331   ([12301](https://github.com/civicrm/civicrm-core/pull/12301))**
 332
 333 - **Make Send SMS permission independent of Edit Contact permission
 334   ([12067](https://github.com/civicrm/civicrm-core/pull/12067))**
 335
 336   You no longer need the permission to edit a contact (in addition to the Send
 337   SMS permission) to send the contact a SMS message.
 338
 339 - **[dev/core#134](https://lab.civicrm.org/dev/core/issues/134) Search Builder
 340   broken filter for Source Contact ID
 341   ([12181](https://github.com/civicrm/civicrm-core/pull/12181))**
 342
 343 - **[dev/core#140](https://lab.civicrm.org/dev/core/issues/140) add missing
 344   pseudoconstant for `option_group_id` in CustomField.xml
 345   ([12195](https://github.com/civicrm/civicrm-core/pull/12195))**
 346
 347   Extensions creating custom fields can now refer to option groups by name
 348   rather than ID.
 349
 350 - **[dev/accessiblity#3](https://lab.civicrm.org/dev/accessibility/issues/3) Add
 351   aria-label (and label?) to form elements missing them
 352   ([12209](https://github.com/civicrm/civicrm-core/pull/12209) and
 353   [213](https://github.com/civicrm/civicrm-packages/pull/213)) (partial work)**
 354
 355   Besides adding `aria-label` attributes to sub-elements of the Quickform
 356   date field, event info pages no longer wrap basic information labels in
 357   `<label>` tags.
 358
 359 - **[CRM-20711](https://issues.civicrm.org/jira/browse/CRM-20711) Error - DB
 360   Constraint Violation - GroupContact, get API
 361   ([12408](https://github.com/civicrm/civicrm-core/pull/12408))**
 362
 363   This adds the `location_id` field to the `civicrm_group_contact` table on
 364   older sites that lack it.
 365
 366 - **[dev/core#152](https://lab.civicrm.org/dev/core/issues/152) -
 367   AdvMulti-Select cleanup
 368   ([531](https://github.com/civicrm/civicrm-drupal/pull/531)) (follow-up work)**
 369
 370   This removes a couple of references to the now-removed "Advanced Multi-select"
 371   custom field type
 372
 373 - **Upgrade Mime_mail to fix issues with PHP7.2
 374   ([205](https://github.com/civicrm/civicrm-packages/pull/205))**
 375
 376 - **Apply fixes to have DB package support PHP7.2
 377   ([207](https://github.com/civicrm/civicrm-packages/pull/207))**
 378
 379 - **[dev/core#117](https://lab.civicrm.org/dev/core/issues/117) Remove usage of
 380   `each()` This is deprecated in php7.2
 381   ([211](https://github.com/civicrm/civicrm-packages/pull/211)) (follow-up
 382   work)**
 383
 384 - **Declare Subparts as array in mimePart to support PHP7.2
 385   ([210](https://github.com/civicrm/civicrm-packages/pull/210))**
 386
 387 - **[CRM-19798](https://issues.civicrm.org/jira/browse/CRM-19798) Memory leak in
 388   API3 EntityTag get operations
 389   ([12276](https://github.com/civicrm/civicrm-core/pull/12276))**
 390
 391 ### CiviCase
 392
 393 - **Fix regression on case export from recent export fix
 394   ([12588](https://github.com/civicrm/civicrm-core/pull/12588))**
 395
 396   This resolves undefined property PHP notices when exporting cases.
 397
 398 - **[dev/core#24](https://lab.civicrm.org/dev/core/issues/24) Passing an array
 399   for contact_id/client_id to Case.Create API when updating an existing case
 400   causes case to be "reassigned"
 401   ([11830](https://github.com/civicrm/civicrm-core/pull/11830))**
 402
 403 - **[CRM-21815](https://issues.civicrm.org/jira/browse/CRM-21815) On re-opening
 404   a civicase - Case Coordinator (and other roles) are not reinstated
 405   ([11736](https://github.com/civicrm/civicrm-core/pull/11736))**
 406
 407 - **[dev/core#165](https://lab.civicrm.org/dev/core/issues/165) Bad link in
 408   civicrm/case/activity/view breadcrumb
 409   ([12279](https://github.com/civicrm/civicrm-core/pull/12279))**
 410
 411 ### CiviContribute
 412
 413 - **[CRM-21637](https://issues.civicrm.org/jira/browse/CRM-21637) Search
 414   Criteria for Card Type ID and Card Number not respected in Batch
 415   ([11495](https://github.com/civicrm/civicrm-core/pull/11495))**
 416
 417   The card type and card number filters for financial transactions in the
 418   accounting batch interface now work as expected.
 419
 420 - **[CRM-21854](https://issues.civicrm.org/jira/browse/CRM-21854) Contribution
 421   start date and end dates are not respected
 422   ([11881](https://github.com/civicrm/civicrm-core/pull/11881) and
 423   [12504](https://github.com/civicrm/civicrm-core/pull/12504))**
 424
 425 - **[dev/core#264](https://lab.civicrm.org/dev/core/issues/264) Fatal Error on
 426   editing Financial Transaction
 427   ([12502](https://github.com/civicrm/civicrm-core/pull/12502))**
 428
 429 - **[dev/core#220](https://lab.civicrm.org/dev/core/issues/220) State
 430   province/country doesn't show properly in the report
 431   ([12390](https://github.com/civicrm/civicrm-core/pull/12390))**
 432
 433   This resolves a bug in the Contribution History by Relationship report where
 434   strange values would appear for the State/Province and Country fields.
 435
 436 - **[dev/core#202](https://lab.civicrm.org/dev/core/issues/202) Empty row under
 437   currency drop down
 438   ([12356](https://github.com/civicrm/civicrm-core/pull/12356))**
 439
 440   A warning now appears when a site has a disabled currency that is set as
 441   default.
 442
 443 - **[dev/core#88](https://lab.civicrm.org/dev/core/issues/88) Make sure
 444   `financial_type_id` is set when a contribution is created
 445   ([11907](https://github.com/civicrm/civicrm-core/pull/11907))**
 446
 447   This resolves a bug where the financial type would not be set on a one-time
 448   contribution made through a contribution page.
 449
 450 - **[dev/core#170](https://lab.civicrm.org/dev/core/issues/170) contribution
 451   detail report errors when soft credits column is exposed
 452   ([12281](https://github.com/civicrm/civicrm-core/pull/12281) and
 453   [12282](https://github.com/civicrm/civicrm-core/pull/12282))**
 454
 455 - **Fix e-notice, remove legacy code pattern
 456   ([12298](https://github.com/civicrm/civicrm-core/pull/12298))**
 457
 458   This resolves a PHP notice when printing contribution receipts in bulk.
 459
 460 - **[dev/core#56](https://lab.civicrm.org/dev/core/issues/56) Cancel Recurring
 461   Contribution activity should have a source record id
 462   ([11964](https://github.com/civicrm/civicrm-core/pull/11964))**
 463
 464   The activity created when cancelling a recurring contribution now has the
 465   recurring contribution ID as the `source_record_id`.
 466
 467 - **[dev/financial#14](https://lab.civicrm.org/dev/financial/issues/14) PayPal
 468   Express recurring payment causes warning messages
 469   ([12091](https://github.com/civicrm/civicrm-core/pull/12091))**
 470
 471 - **[CRM-20697](https://issues.civicrm.org/jira/browse/CRM-20697) Online pay now
 472   anomalies (contribution transfer to new contact)
 473   ([11578](https://github.com/civicrm/civicrm-core/pull/11578))**
 474
 475   The Pay Now form now uses contact ID and checksum to validate the
 476   contribution's contact to avoid creating new contacts when an anonymous
 477   visitor fulfills a pending contribution.
 478
 479 ### CiviEvent
 480
 481 - **[dev/core#272](https://lab.civicrm.org/dev/core/issues/272) Fatal Error
 482   (Regression) on PCP pages associated with Events
 483   ([12533](https://github.com/civicrm/civicrm-core/pull/12533))**
 484
 485 - **[dev/core#124](https://lab.civicrm.org/dev/core/issues/124) Registration
 486   approval issues ([12160](https://github.com/civicrm/civicrm-core/pull/12160)
 487   and [12417](https://github.com/civicrm/civicrm-core/pull/12417))**
 488
 489   This resolves a PHP warning and some confusing aspects of handling event
 490   registration approvals.
 491
 492 ### CiviGrant
 493
 494 - **[dev/core#187](https://lab.civicrm.org/dev/core/issues/187) Fix typo in
 495   `CRM_Grant_Form_Task` that prevents retrieving session key from URL
 496   ([12317](https://github.com/civicrm/civicrm-core/pull/12317))**
 497
 498 ### CiviMail
 499
 500 - **[dev/core#133](https://lab.civicrm.org/dev/core/issues/133) Reply-to field
 501   with empty string get saved in DB as `NULL`
 502   ([12176](https://github.com/civicrm/civicrm-core/pull/12176))**
 503
 504 - **[CRM-20320](https://issues.civicrm.org/jira/browse/CRM-20320) Error in PEAR
 505   SMTP causes mailing job to fail when an error occurs during one connection
 506   ([11840](https://github.com/civicrm/civicrm-core/pull/11840))**
 507
 508   CiviMail will now disconnect the SMTP connection when a connection error is
 509   detected and record the group of messages as not delivered.  This allows it to
 510   reconnect later and send the messages.
 511
 512 - **[CRM-17753](https://issues.civicrm.org/jira/browse/CRM-17753) Newsletter
 513   confirmation emails shouldn't use do-not-reply@yourdomain.org
 514   ([12270](https://github.com/civicrm/civicrm-core/pull/12270)) (preliminary
 515   work)**
 516
 517 - **[CRM-21779](https://issues.civicrm.org/jira/browse/CRM-21779) Civimail
 518   allows adding current draft mailing recipients to recipients field
 519   ([11724](https://github.com/civicrm/civicrm-core/pull/11724))**
 520
 521 ### CiviMember
 522
 523 - **[dev/membership#4](https://lab.civicrm.org/dev/membership/issues/4) Admin
 524   Membership type is displayed on Public contribution page.
 525   ([12178](https://github.com/civicrm/civicrm-core/pull/12178))**
 526
 527 - **[dev/core#276](https://lab.civicrm.org/dev/core/issues/276) Undefined index:
 528   is_override on submit credit card membership
 529   ([12563](https://github.com/civicrm/civicrm-core/pull/12563))**
 530
 531 - **[dev/core#151](https://lab.civicrm.org/dev/core/issues/151) Action to Update
 532   Recurring Contributions From Membership View is Never Shown
 533   ([12228](https://github.com/civicrm/civicrm-core/pull/12228))**
 534
 535   The table to view recurring contributions on a membership now displays the
 536   Edit action where appropriate.
 537
 538 - **[CRM-21682](https://issues.civicrm.org/jira/browse/CRM-21682) Automatic
 539   membership renewal fixes
 540   ([12313](https://github.com/civicrm/civicrm-core/pull/12313) and
 541   [12314](https://github.com/civicrm/civicrm-core/pull/12314)) (preliminary
 542   work)**
 543
 544 - **[CRM-21177](https://issues.civicrm.org/jira/browse/CRM-21177) Wrong interval
 545   of recurring payment for auto-renewing membership
 546   ([12289](https://github.com/civicrm/civicrm-core/pull/12289)) (preliminary
 547   work)**
 548
 549 ### Joomla Integration
 550
 551 - **[dev/joomla#1](https://lab.civicrm.org/dev/joomla/issues/1) CiviEvent menu
 552   listing showing old events
 553   ([46](https://github.com/civicrm/civicrm-joomla/pull/46))**
 554
 555 ### WordPress Integration
 556
 557 - **[dev/wordpress#1](https://lab.civicrm.org/dev/wordpress/issues/1)
 558   CiviCRM-WordPress - Gutenberg Compatibility: Do not parse shortcodes in REST
 559   context ([130](https://github.com/civicrm/civicrm-wordpress/pull/130))**
 560
 561 - **[CRM-21565](https://issues.civicrm.org/jira/browse/CRM-21565) Change mkdir
 562   to use correct and more secure mode numbers
 563   ([120](https://github.com/civicrm/civicrm-wordpress/pull/120))**
 564
 565 ## <a name="misc"></a>Miscellany
 566
 567 - **(NFC) Convert files to use linux line endings not windows
 568   ([12531](https://github.com/civicrm/civicrm-core/pull/12531))**
 569
 570 - **Move DAO function to DAO class, call it from Merge class
 571   ([12340](https://github.com/civicrm/civicrm-core/pull/12340))**
 572
 573 - **NFC code cleanup for AuthNet, Paypal, PaypalPro IPNs
 574   ([12386](https://github.com/civicrm/civicrm-core/pull/12386))**
 575
 576 - **[dev/core#203](https://lab.civicrm.org/dev/core/issues/203) Cruft code in
 577   `CRM_Core_BAO_OptionGroup::add()`
 578   ([12357](https://github.com/civicrm/civicrm-core/pull/12357))**
 579
 580 - **Remove unused instances of usedTable
 581   ([12341](https://github.com/civicrm/civicrm-core/pull/12341) and
 582   [12349](https://github.com/civicrm/civicrm-core/pull/12349))**
 583
 584 - **(NFC) CiviUnitTestCase - Fix edge-case for mis-reported error
 585   ([12347](https://github.com/civicrm/civicrm-core/pull/12347))**
 586
 587 - **NFC Code cleanup to core task class
 588   ([12316](https://github.com/civicrm/civicrm-core/pull/12316))**
 589
 590 - **[NFC] Stop passing no-longer-part-of-signature variable
 591   ([12329](https://github.com/civicrm/civicrm-core/pull/12329))**
 592
 593 - **Fix typo in api explorer sample code
 594   ([12324](https://github.com/civicrm/civicrm-core/pull/12324))**
 595
 596 - **Remove unused code variable
 597   ([12299](https://github.com/civicrm/civicrm-core/pull/12299))**
 598
 599 - **Confirm & lock in group.get handling of is_active
 600   ([12295](https://github.com/civicrm/civicrm-core/pull/12295))**
 601
 602 - **Remove unused function getRecuringTransactionStatus from PayflowPro c…
 603   ([12294](https://github.com/civicrm/civicrm-core/pull/12294))**
 604
 605 - **Add upgrade function for message templates that does not involve copying the
 606   whole template ([12224](https://github.com/civicrm/civicrm-core/pull/12224))**
 607
 608 - **Function extraction BAO_Export class
 609   ([12288](https://github.com/civicrm/civicrm-core/pull/12288))**
 610
 611 - **Partial refactor of completeMembershipFromContribution
 612   ([12271](https://github.com/civicrm/civicrm-core/pull/12271))**
 613
 614 - **[NFC] Fix line endings (Jenkins where were you)
 615   ([12280](https://github.com/civicrm/civicrm-core/pull/12280))**
 616
 617 - **Towards fixing household merge export, extract function, add test, fix prev
 618   ([12272](https://github.com/civicrm/civicrm-core/pull/12272))**
 619
 620 - **Standardise line endings away from windows line endings to linux
 621   ([212](https://github.com/civicrm/civicrm-packages/pull/212))**
 622
 623 ## <a name="credits"></a>Credits
 624
 625 This release was developed by the following code authors:
 626
 627 AGH Strategies - Alice Frumin, Andrew Hunt; Agileware - Alok Patel; Australian
 628 Greens - Seamus Lee; Bastien Ho; Caltha - Tomasz Pietrzkowski; CiviCoop - Jaap
 629 Jansma; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Yashodha Chaku; CompuCorp -
 630 Camilo Rodriguez, Michael Devery, René Olivo, Vinu Varshith Sekar; Electronic
 631 Frontier Foundation - Mark Burdett; Fuzion - Jitendra Purohit; Ginkgo Street
 632 Labs - Frank Gómez; JMA Consulting - Monish Deb; Johan Vervloet; John
 633 Kingsnorth; Kanzu Code - Carl Andrew Lema; Left Join Labs - Sean Madsen; MJW
 634 Consulting - Matthew Wire; Pradeep Nayak; Romain Thouvenin; Squiffle Consulting -
 635 Aidan Saunders; Tadpole Collective - Kevin Cristiano; Third Sector Design -
 636 Michael McAndrew; Tom Bloor; Wikimedia Foundation - Eileen McNaughton
 637
 638 Most authors also reviewed code for this release; in addition, the following
 639 reviewers contributed their comments:
 640
 641 Agileware - Justin Freeman; baernm; Blackfly Solutions - Alan Dixon; Bob
 642 Silvern; Borislav Zlatanov; Caltha - Michal Mach; cartbar; Christian Wach;
 643 Circle Interactive - Dave Jenkins; CiviCoop - Erik Hommel; Community Builders -
 644 Andrew Perry; CompuCorp - Guanhuan Chen, Omar Abu Hussein; Coop SymbioTIC -
 645 Mathieu Lutfy; Drupal Association - Lizz Trudeau; Evan Chute; Forest CRM
 646 Consulting - Tamar Meir; Freeform Solutions - Herb van den Dool; Ginkgo Street
 647 Labs - Dan O'Brien; Hugo do Carmo; JMA Consulting - Joe Murray; Lemniscus - Noah
 648 Miller; Lighthouse Design and Consulting - Brian Shaughnessy; Megaphone
 649 Technology Consulting - Jon Goldberg; MJCO - Mikey O'Toole; Oxfam Germany -
 650 Thomas Schüttler; Richard van Oosterhout; Robin Fenwick; Semper IT - Karin
 651 Gerritsen; Stephen Palmstrom; Tech To The People - Xavier Dutoit; Timbsoft
 652 Technologies - Tunbola Ogunwande
 653
 654 ## <a name="feedback"></a>Feedback
 655
 656 These release notes are edited by Andrew Hunt.  If you'd like to provide
 657 feedback on them, please log in to https://chat.civicrm.org/civicrm and contact
 658 `@agh1`.