Merge pull request #23934 from eileenmcnaughton/url_tokens
[civicrm-core.git] / release-notes / 5.35.0.md
1 # CiviCRM 5.35.0
2
3 Released March 3, 2021
4
5 - **[Synopsis](#synopsis)**
6 - **[Features](#features)**
7 - **[Bugs resolved](#bugs)**
8 - **[Miscellany](#misc)**
9 - **[Credits](#credits)**
10 - **[Feedback](#feedback)**
11
12 ## <a name="synopsis"></a>Synopsis
13
14 | *Does this version...?* | |
15 |:--------------------------------------------------------------- |:-------:|
16 | Fix security vulnerabilities? | no |
17 | **Change the database schema?** | **yes** |
18 | **Alter the API?** | **yes** |
19 | **Require attention to configuration options?** | **yes** |
20 | **Fix problems installing or upgrading to a previous version?** | **yes** |
21 | **Introduce features?** | **yes** |
22 | **Fix bugs?** | **yes** |
23
24 ## <a name="features"></a>Features
25
26 ### Core CiviCRM
27
28 - **Improve activity import to support updates (Work Towards
29 [dev/core#2308](https://lab.civicrm.org/dev/core/-/issues/2308):
30 [19439](https://github.com/civicrm/civicrm-core/pull/19439))**
31
32 Ensures when importing activities, activity fields are not required if the
33 activity id is present, so that one can update existing activities via import.
34
35 - **Proposal - make 5.33 the last CiviCRM version to support php 7.1 (agreed)
36 and mysql 5.6 (deferred) (& equivalent MariaDB version) (Work Towards
37 [dev/core#2204](https://lab.civicrm.org/dev/core/-/issues/2204):
38 [126](https://github.com/civicrm/civicrm-backdrop/pull/126),
39 [637](https://github.com/civicrm/civicrm-drupal/pull/637),
40 [238](https://github.com/civicrm/civicrm-wordpress/pull/238) and
41 [19390](https://github.com/civicrm/civicrm-core/pull/19390))**
42
43 Update the minimum php install version to be 7.2.
44
45 - **Add explicit box-sizing to crm-flex-box style
46 ([19325](https://github.com/civicrm/civicrm-core/pull/19325))**
47
48 Ensures consistent box sizing when using the new `crm-flex-box` css class,
49 for consistency with or without Bootstrap 3.
50
51 - **Search-kit - better user experience for bulk updates
52 ([dev/core#2310](https://lab.civicrm.org/dev/core/-/issues/2310):
53 [19425](https://github.com/civicrm/civicrm-core/pull/19425))**
54
55 Adds a batch system to search kit. This avoids server timeouts, and improves
56 the user experience.
57
58 - **Searchkit - separate calls for results & count
59 ([dev/core#2312](https://lab.civicrm.org/dev/core/-/issues/2312):
60 [19426](https://github.com/civicrm/civicrm-core/pull/19426))**
61
62 Improves SearchKit results loading time in the admin UI.
63
64 - **Searchkit - activity record type not intuitive
65 ([dev/core#2313](https://lab.civicrm.org/dev/core/-/issues/2313):
66 [19429](https://github.com/civicrm/civicrm-core/pull/19429))**
67
68 Makes joins in SearchKit more intuitive by automatically adding commonly-used
69 default conditions.
70
71 - **SearchKit: Add support for multi-record custom field groups
72 ([19452](https://github.com/civicrm/civicrm-core/pull/19452))**
73
74 Adds support in SearchKit for multi-record custom field group pseudo-entities
75 to be added to the search as joins.
76
77 - **Modifying lists of Country/StateProvince/County (Work Towards
78 [dev/core#2329](https://lab.civicrm.org/dev/core/-/issues/2329):
79 [19448](https://github.com/civicrm/civicrm-core/pull/19448))**
80
81 Adds an `is_active` field to Country, StateProvince and County elements so
82 that they can be disabled.
83
84 - **APIv4 - Enable getFields to find fields across implicit FK joins
85 ([19516](https://github.com/civicrm/civicrm-core/pull/19516))**
86
87 Makes it possible to return fields from other entities using APIv4.
88
89 - **Add v4 pledge api
90 ([19297](https://github.com/civicrm/civicrm-core/pull/19297))**
91
92 Adds the Pledge entity to APIv4.
93
94 - **Add pledge payment api
95 ([19436](https://github.com/civicrm/civicrm-core/pull/19436))**
96
97 Adds the Pledge Payment entity to APIv4.
98
99 - **Payment API - Add description of `order_reference` parameter
100 ([19449](https://github.com/civicrm/civicrm-core/pull/19449))**
101
102 Adds a spec for the `Payment.order_reference` parameter so that is shows up in
103 the API explorer and is a little more discoverable.
104
105 - **API Explorer - Fix URL encoding in REST examples
106 ([19450](https://github.com/civicrm/civicrm-core/pull/19450))**
107
108 Improves the REST examples generated in "Support => Developer => Api Explorer
109 v3".
110
111 - **Search Builder - Enhance UI with Select2 and EntityRef
112 ([19471](https://github.com/civicrm/civicrm-core/pull/19471))**
113
114 Improves the UI of Search Builder (the classic one in core, not the new Search
115 Kit extension) by using Select2 dropdowns for selecting options &
116 autocompleting contacts, events, etc instead of needing to enter numeric ids.
117
118 - **Add "label_field" metadata to entities
119 ([19504](https://github.com/civicrm/civicrm-core/pull/19504) and
120 [19546](https://github.com/civicrm/civicrm-core/pull/19546))**
121
122 Adds a "label_field" metadata to the schema for entities so that one can know
123 how a entity should be displayed by looking at the metadata.
124
125 - **Select2 - Improve styles for disabled, loading elements
126 ([19430](https://github.com/civicrm/civicrm-core/pull/19430))**
127
128 Improves Select2 user experience in Greenwich.
129
130 - **Tabbed interface for organizing afforms by type
131 ([19395](https://github.com/civicrm/civicrm-core/pull/19395))**
132
133 Creates afform types and a tabbed interface in the Admin section, and adds
134 support for embedding search displays into afform fieldsets.
135
136 - **Add setting default to speed up cache flush
137 ([19383](https://github.com/civicrm/civicrm-core/pull/19383))**
138
139 Adds a define to civicrm.settings.php that speeds up cache flushes
140
141 - **Add pseudoconstant for Relationship.relationship_type_id
142 ([19278](https://github.com/civicrm/civicrm-core/pull/19278))**
143
144 Updates the relationship schema to add a pseudoconstant to the
145 relationship_type_id field.
146
147 ### CiviContribute
148
149 - **Unhide contributioncancelactions core extension
150 ([19500](https://github.com/civicrm/civicrm-core/pull/19500))**
151
152 Makes the Contributioncancelactions extension visible and disabling it
153 supported.
154
155 ### CiviMail
156
157 - **Support tracking URLs with tokens in query strings
158 ([dev/mail#81](https://lab.civicrm.org/dev/mail/-/issues/81):
159 [19386](https://github.com/civicrm/civicrm-core/pull/19386))**
160
161 When delivering a mail-blast, Flexmailer replaces most URLs with trackable
162 URLs. This expands tracking support for URLs that include tokens.
163
164 ### Drupal Integration
165
166 - **allow filtering by empty event end, registration start, registration end
167 dates ([634](https://github.com/civicrm/civicrm-drupal/pull/634))**
168
169 Makes it possible to filter by empty event date fields in views.
170
171 - **Advice in failure message is out of date
172 ([633](https://github.com/civicrm/civicrm-drupal/pull/633))**
173
174 Improves error message when unable to load CRM/Core/Config.php.
175
176 ## <a name="bugs"></a>Bugs resolved
177
178 ### Core CiviCRM
179
180 - **search on relationship and case
181 ([18779](https://github.com/civicrm/civicrm-core/pull/18779))**
182
183 Ensures Advanced search filters correctly when displaying related contacts and
184 searching with case parameters.
185
186 - **Don't check for .git in the isDevelopment() function
187 ([dev/core#2241](https://lab.civicrm.org/dev/core/-/issues/2241):
188 [19361](https://github.com/civicrm/civicrm-core/pull/19361))**
189
190 Deprecates direct calls to `isDevelopment()`.
191
192 - **Adding Contacts to a New Group via Manage Groups Page Failure
193 ([dev/core#2333](https://lab.civicrm.org/dev/core/-/issues/2333):
194 [19472](https://github.com/civicrm/civicrm-core/pull/19472))**
195
196 Fixes an issue when creating a group from a letter page of search results.
197
198 - **Oauth Redirect URL reporterror_civicrm_handler
199 ([dev/core#2350](https://lab.civicrm.org/dev/core/-/issues/2350):
200 [19492](https://github.com/civicrm/civicrm-core/pull/19492))**
201
202 Ensures when using the Oauth extension, setting a fatalErrorHandler does not
203 override the redirect url.
204
205 - **Search Kit: Search kit, contribution search - financial type field is odd
206 ([dev/core#2349](https://lab.civicrm.org/dev/core/-/issues/2349) and
207 [dev/core#2347](https://lab.civicrm.org/dev/core/-/issues/2347):
208 [19489](https://github.com/civicrm/civicrm-core/pull/19489))**
209
210 Fixes two SearchKit bugs:
211
212 - Contribution Search, financial type return empty
213 - Preview button on table display form not working
214
215 - **Afform - Misc tweaks, validation & bug fixes
216 ([19496](https://github.com/civicrm/civicrm-core/pull/19496))**
217
218 Adds basic validation to server_route in the Afform GUI, only permitting
219 paths beginning with "civicrm/". Also re-labels the menu item and page
220 title to "Form Builder" and resets server_route and is_dashlet when cloning.
221 And fixes several bugs in Afform & Search Kit.
222
223 - **Afform - Fix form submit button
224 ([19460](https://github.com/civicrm/civicrm-core/pull/19460))**
225
226 Ensures clicking Submit on an afform actually submits the form.
227
228 - **Afform GUI enhancements & Search Kit integration
229 ([19455](https://github.com/civicrm/civicrm-core/pull/19455))**
230
231 Fixes errors in afform GUI when creating a new block from the admin screen and
232 when clicking "Save as Block"
233
234 - **Afform - Drop directive support for attribute, only support elements as
235 afforms ([19438](https://github.com/civicrm/civicrm-core/pull/19438) and
236 [19670](https://github.com/civicrm/civicrm-core/pull/19670))**
237
238 Afform no longer responds to attributes set for standard HTML elements; you
239 must use a special element to invoke an Afform.
240
241 - **Greenwich - fix list margin added by some CMS themes
242 ([19423](https://github.com/civicrm/civicrm-core/pull/19423))**
243
244 Fixes a style conflict between some CMS themes and Greenwich, causing tabs to
245 shift to the right.
246
247 - **Flag that Embedded Activity Revisions setting is unsupported and deprecated
248 ([19422](https://github.com/civicrm/civicrm-core/pull/19422))**
249
250 Adds more documentation to the 'Enable Embedded Activity Revisions' setting to
251 make it explicit that it is deprecated.
252
253 - **Use php to require an array
254 ([19370](https://github.com/civicrm/civicrm-core/pull/19370))**
255
256 Removes is_array check in favor of php strict typing.
257
258 - **Fix rendering of Dashlet placeholder
259 ([dev/core#2306](https://lab.civicrm.org/dev/core/-/issues/2306):
260 [19413](https://github.com/civicrm/civicrm-core/pull/19413))**
261
262 Prevents panel jumping when dragging dashlets.
263
264 - **Dashboard: Improve status messages when moving/deleting dashlets
265 ([19358](https://github.com/civicrm/civicrm-core/pull/19358))**
266
267 Ensures a in-progress message is displayed when moving/deleting dashlets.
268
269 - **Using %1%2 in ts() generates confusing output in transifex
270 ([dev/translation#64](https://lab.civicrm.org/dev/translation/-/issues/64):
271 [19453](https://github.com/civicrm/civicrm-core/pull/19453))**
272
273 - **Upgrader (5.34) - Handle unsavable characters in decoded SMTP password
274 ([19711](https://github.com/civicrm/civicrm-core/pull/19711))**
275
276 This resolves upgrade problems as older sites upgrade through 5.34.0, have
277 encrypted SMTP credentials, and have 8-bit characters.
278
279 - **Issue with importing to checkbox type fields where label is the same as
280 database value (may affect other types too)
281 ([dev/core#866](https://lab.civicrm.org/dev/core/-/issues/866) and
282 [dev/core#1318](https://lab.civicrm.org/dev/core/-/issues/1318):
283 [19111](https://github.com/civicrm/civicrm-core/pull/19111))**
284
285 - **Logging tables shown as 'different' incorrectly after upgrading to MariaDB
286 10.4.x ([dev/core#2305](https://lab.civicrm.org/dev/core/-/issues/2305):
287 [19412](https://github.com/civicrm/civicrm-core/pull/19412))**
288
289 - **Mapping a contact gives invalid argument supplied.
290 ([dev/core#2307](https://lab.civicrm.org/dev/core/-/issues/2307):
291 [19414](https://github.com/civicrm/civicrm-core/pull/19414))**
292
293 - **Inconsistent line breaks on custom field edit page for description text
294 ([dev/core#2328](https://lab.civicrm.org/dev/core/-/issues/2328):
295 [19444](https://github.com/civicrm/civicrm-core/pull/19444))**
296
297 - **Creating an afform without civicrm/ in the url breaks the site
298 ([dev/core#2340](https://lab.civicrm.org/dev/core/-/issues/2340):
299 [19464](https://github.com/civicrm/civicrm-core/pull/19464))**
300
301 - **Afform api explorer: has_local, has_base do not present as bool
302 ([dev/core#2341](https://lab.civicrm.org/dev/core/-/issues/2341):
303 [19465](https://github.com/civicrm/civicrm-core/pull/19465))**
304
305 - **APIv4 - Fix bug when using relative date filters in ON clause of a join
306 ([19514](https://github.com/civicrm/civicrm-core/pull/19514))**
307
308 - **Search Kit - Fix display pager and improve error handling
309 ([19479](https://github.com/civicrm/civicrm-core/pull/19479))**
310
311 - **Afform - delete unused, nonfunctional apis
312 ([19432](https://github.com/civicrm/civicrm-core/pull/19432))**
313
314 - **Afform GUI - Fix errors when creating & saving blocks
315 ([19519](https://github.com/civicrm/civicrm-core/pull/19519))**
316
317 - **Greenwich: Fix BS3 conflict with html5 search clear button
318 ([19461](https://github.com/civicrm/civicrm-core/pull/19461))**
319
320 - **Move require once in api kernel to support edge cases
321 ([19513](https://github.com/civicrm/civicrm-core/pull/19513))**
322
323 - **Token Processor: fix PHP syntax for purifyHTML
324 ([19490](https://github.com/civicrm/civicrm-core/pull/19490))**
325
326 - **Do not set source_contact_id in summary function
327 ([19456](https://github.com/civicrm/civicrm-core/pull/19456))**
328
329 - **Fix missing translate tag
330 ([19451](https://github.com/civicrm/civicrm-core/pull/19451))**
331
332 - **composer.json - Ignore unused variants of Monaco ("dev"/"esm")
333 ([19433](https://github.com/civicrm/civicrm-core/pull/19433))**
334
335 - **"Admin => Misc" - Fix validation of "Maximum File Size"
336 ([19382](https://github.com/civicrm/civicrm-core/pull/19382))**
337
338 - **Fix Redis deprecated warning
339 ([19593](https://github.com/civicrm/civicrm-core/pull/19593))**
340
341 - **SearchKit : use of rows in query cause mysql errors
342 ([dev/core#2360](https://lab.civicrm.org/dev/core/-/issues/2360):
343 [19653](https://github.com/civicrm/civicrm-core/pull/19653))
344
345 - **Decimal Separator - Incorrect format in some views and editions
346 ([dev/core#2394](https://lab.civicrm.org/dev/core/-/issues/2394):
347 [19685](https://github.com/civicrm/civicrm-core/pull/19685) and
348 [19692](https://github.com/civicrm/civicrm-core/pull/19692))**
349
350 - **Account IIF Export Amount Format improper
351 ([dev/financial#166](https://lab.civicrm.org/dev/financial/-/issues/166):
352 [19680](https://github.com/civicrm/civicrm-core/pull/19680))**
353
354 This resolves inconsistency in the money formatting where the currency symbol
355 would be added inappropriately.
356
357 - **Some Multi-Select Custom Fields cannot be saved
358 ([dev/core#2423](https://lab.civicrm.org/dev/core/-/issues/2423):
359 [19698](https://github.com/civicrm/civicrm-core/pull/19698))**
360
361 This resolves the problem that multi-select fields with integer, number, or
362 money data types could not have data stored in them.
363
364 - **Dashboard Query failed to detect existing record for contact
365 ([dev/core#2426](https://lab.civicrm.org/dev/core/-/issues/2426):
366 [19694](https://github.com/civicrm/civicrm-core/pull/19694))**
367
368 This resolves a crash on the CiviCRM dashboard if a user lacks the permission
369 to view their own contact.
370
371 ### CiviCase
372
373 - **Custom Field of type Integer that uses Radio Buttons as Input Type in
374 combination with search range scrambles Case Report Search
375 ([dev/core#2288](https://lab.civicrm.org/dev/core/-/issues/2288):
376 [19339](https://github.com/civicrm/civicrm-core/pull/19339))**
377
378 - **Upgrading an old site with spaces in the case type names and external xml
379 files leads to difficult to resolve status messages
380 ([dev/core#2326](https://lab.civicrm.org/dev/core/-/issues/2326):
381 [19441](https://github.com/civicrm/civicrm-core/pull/19441))**
382
383 - **Sample xml casetype configuration files have label instead of name in the
384 name ([dev/core#2327](https://lab.civicrm.org/dev/core/-/issues/2327):
385 [19442](https://github.com/civicrm/civicrm-core/pull/19442))**
386
387 - **Use exceptions when enabling case component / checking for 'CREATE VIEW'
388 permissions ([19503](https://github.com/civicrm/civicrm-core/pull/19503))**
389
390 ### CiviContribute
391
392 - **Fix pledge action on failed/ cancelled contribution
393 ([dev/core#2206](https://lab.civicrm.org/dev/core/-/issues/2206):
394 [19289](https://github.com/civicrm/civicrm-core/pull/19289))**
395
396 Ensures that Pledge payments are correctly updated when a contribution is
397 cancelled or fails.
398
399 - **Undefined index when putting in a contribution thank-you date without a time
400 ([dev/core#2297](https://lab.civicrm.org/dev/core/-/issues/2297):
401 [19388](https://github.com/civicrm/civicrm-core/pull/19388))**
402
403 - **Cannot edit contribution with revenue recognition date in a past year
404 ([dev/financial#164](https://lab.civicrm.org/dev/financial/-/issues/164):
405 [19454](https://github.com/civicrm/civicrm-core/pull/19454))**
406
407 - **Notice: Undefined property: CRM_Core_DAO::$_context in
408 CRM_Utils_PagerAToZ::createLinks() on contribution page listing
409 ([dev/core#2355](https://lab.civicrm.org/dev/core/-/issues/2355):
410 [19515](https://github.com/civicrm/civicrm-core/pull/19515))**
411
412 - **Set contribution_page_id from template contribution
413 ([19362](https://github.com/civicrm/civicrm-core/pull/19362))**
414
415 - **Fix pledge to not use pass-by-reference
416 ([19400](https://github.com/civicrm/civicrm-core/pull/19400))**
417
418 ### CiviMail
419
420 - **Update permissions for "CiviCRM Admin Menu -> Mailings -> Message Templates"
421 nav item ([19342](https://github.com/civicrm/civicrm-core/pull/19342))**
422
423 Updates the permissions for the "CiviCRM Admin Menu -> Mailings -> Message
424 Templates" navigation item so that if the user has any of the following
425 permissions they can view it:
426
427 - edit user-driven message templates
428 - edit system workflow message templates
429 - edit message templates
430
431 - **When two contacts, Contact A and Contact B have the same email address, if
432 Contact A is deleted then Contact B is incorrectly excluded from mailings,
433 does not receive emails
434 ([19360](https://github.com/civicrm/civicrm-core/pull/19360))**
435
436 ### CiviMembership
437
438 - **Show disabled membership types on contact tab
439 ([19431](https://github.com/civicrm/civicrm-core/pull/19431) and
440 [19594](https://github.com/civicrm/civicrm-core/pull/19594))**
441
442 - **Fix PHP notice if membershipBlock is not defined
443 ([19447](https://github.com/civicrm/civicrm-core/pull/19447))**
444
445 ### Backdrop Integration
446
447 - **UF Settings page for Views CiviCRM integration should not have backticks for
448 Backdrop ([dev/core#2352](https://lab.civicrm.org/dev/core/-/issues/2352):
449 [19491](https://github.com/civicrm/civicrm-core/pull/19491))**
450
451 ### Drupal Integration
452
453 - **Override the DrupalBase getUserObject function with a Drupal8/9 compatible
454 version ([19517](https://github.com/civicrm/civicrm-core/pull/19517))**
455
456 Fixes an error when using the APIv3 `User` entity on Drupal 9.
457
458 - **Drupal7: civicrm_rules - Add/Remove contact from CiviCRM Group works with
459 deprecated method on removal
460 ([dev/drupal#65](https://lab.civicrm.org/dev/drupal/-/issues/65):
461 [580](https://github.com/civicrm/civicrm-drupal/pull/580))**
462
463 - **Drupal9: system_get_info() not available. CiviReport crash.**
464 ([dev/drupal#156](https://lab.civicrm.org/dev/drupal/-/issues/156): [#19725](https://github.com/civicrm/civicrm-core/pull/19725))
465
466 - **Fix deceased date format
467 ([607](https://github.com/civicrm/civicrm-drupal/pull/607))**
468
469 ### WordPress Integration
470
471 - **List of groups in search form and create new contact screen not respecting
472 ACLs ([dev/wordpress#86](https://lab.civicrm.org/dev/wordpress/-/issues/86):
473 [19372](https://github.com/civicrm/civicrm-core/pull/19372))**
474
475 ## <a name="misc"></a>Miscellany
476
477 - **Bump socket.io from 2.3.0 to 2.4.1
478 ([19427](https://github.com/civicrm/civicrm-core/pull/19427))**
479
480 - **Afform - code refactoring for angular best practices
481 ([19352](https://github.com/civicrm/civicrm-core/pull/19352))**
482
483 - **Token plan - what is it (Code Cleanup for
484 [dev/core#2303](https://lab.civicrm.org/dev/core/-/issues/2303):
485 [19409](https://github.com/civicrm/civicrm-core/pull/19409))**
486
487 - **Deprecate BaseIPN functions validateData & LoadObject
488 ([dev/financial#148](https://lab.civicrm.org/dev/financial/-/issues/148):
489 [19416](https://github.com/civicrm/civicrm-core/pull/19416))**
490
491 - **Comment intent to remove call to transition components
492 ([19507](https://github.com/civicrm/civicrm-core/pull/19507))**
493
494 - **CRM_Core_BAO_MessageTemplate::sendReminder() is not used anywhere
495 ([19502](https://github.com/civicrm/civicrm-core/pull/19502))**
496
497 - **Move another deprecated utils function
498 ([19365](https://github.com/civicrm/civicrm-core/pull/19365))**
499
500 - **Deprecate Pledge::add() function
501 ([19411](https://github.com/civicrm/civicrm-core/pull/19411))**
502
503 - **Cleanup a couple of unnecessary references
504 ([19420](https://github.com/civicrm/civicrm-core/pull/19420))**
505
506 - **Update contributor-key.yml
507 ([19459](https://github.com/civicrm/civicrm-core/pull/19459))**
508
509 - **update contributor-key.yml and CONTRIBUTORS.txt file
510 ([19446](https://github.com/civicrm/civicrm-core/pull/19446))**
511
512 - **Remove unnecessary call to error_reporting in drupal 7 integration code
513 ([19445](https://github.com/civicrm/civicrm-core/pull/19445))**
514
515 - **Remove call to loadRelatedObjects
516 ([19407](https://github.com/civicrm/civicrm-core/pull/19407))**
517
518 - **Remove always true if
519 ([19499](https://github.com/civicrm/civicrm-core/pull/19499))**
520
521 - **Remove another use of loadRelatedObjects() function
522 ([19505](https://github.com/civicrm/civicrm-core/pull/19505))**
523
524 - **Test framework - API4 DateTest::testRelativeDateRanges will fail on the last
525 day of Jan, Mar, May, Aug, Oct
526 ([dev/core#2339](https://lab.civicrm.org/dev/core/-/issues/2339):
527 [19462](https://github.com/civicrm/civicrm-core/pull/19462))**
528
529 - **[Test framework] Prevent intermittently failing relationship test
530 ([19424](https://github.com/civicrm/civicrm-core/pull/19424))**
531
532 - **[Test] Extend new membership form to cover multi-line renew + minor cleanup
533 ([19404](https://github.com/civicrm/civicrm-core/pull/19404))**
534
535 - **[REF] Remove some of those old php4 &s
536 ([19419](https://github.com/civicrm/civicrm-core/pull/19419))**
537
538 - **REF Move buildMembershipBlock function from ContributionPage to
539 Main/Confirm/Thankyou page
540 ([19467](https://github.com/civicrm/civicrm-core/pull/19467))**
541
542 - **REF Permit installing of replacement extensions during upgrade for ob…
543 ([19391](https://github.com/civicrm/civicrm-core/pull/19391))**
544
545 - **[REF] Remove objects var from PaypalProIPN
546 ([19440](https://github.com/civicrm/civicrm-core/pull/19440))**
547
548 - **[REF] Remove seemingly unreachable attempt to format activity_date_time
549 ([19437](https://github.com/civicrm/civicrm-core/pull/19437))**
550
551 - **[REF] Move related code to be together
552 ([19418](https://github.com/civicrm/civicrm-core/pull/19418))**
553
554 - **[REF] Simplify activity import validation
555 ([19373](https://github.com/civicrm/civicrm-core/pull/19373))**
556
557 - **[#REF] Cleanup recently added code fixing dev/core#2307 for the fact …
558 ([19415](https://github.com/civicrm/civicrm-core/pull/19415))**
559
560 - **[REF] Move instantiation of Order class to earlier in function
561 ([19402](https://github.com/civicrm/civicrm-core/pull/19402))**
562
563 - **[REF] Remove copy & paste code from Activity mapping form
564 ([19488](https://github.com/civicrm/civicrm-core/pull/19488))**
565
566 - **[REF] Fix Order class to not reload if already loaded
567 ([19403](https://github.com/civicrm/civicrm-core/pull/19403))**
568
569 - **[REF] Move code closer to where it is used
570 ([19410](https://github.com/civicrm/civicrm-core/pull/19410))**
571
572 - **[REF] Param simplification
573 ([19406](https://github.com/civicrm/civicrm-core/pull/19406))**
574
575 - **[REF] Minor cleanup on emailReceipt
576 ([19405](https://github.com/civicrm/civicrm-core/pull/19405))**
577
578 - **REF Ensure that when doing RLIKE BINARY the field is cast as BINARY t…
579 ([19399](https://github.com/civicrm/civicrm-core/pull/19399))**
580
581 - **[REF] Remove function that is the same as parent
582 ([19369](https://github.com/civicrm/civicrm-core/pull/19369))**
583
584 - **[REF] Standardise methods of determining isTest
585 ([19417](https://github.com/civicrm/civicrm-core/pull/19417))**
586
587 - **REF Update CiviCRM default PEAR Error handling to be exception rather…
588 ([19323](https://github.com/civicrm/civicrm-core/pull/19323))**
589
590 - **[REF] Extract logical functions from sendTemplate
591 ([19510](https://github.com/civicrm/civicrm-core/pull/19510) and
592 [19563](https://github.com/civicrm/civicrm-core/pull/19563))**
593
594 - **[REF] Move sendNotification out of recur, remove unused related_contact
595 ([19443](https://github.com/civicrm/civicrm-core/pull/19443))**
596
597 - **[REF] Remove invalid attempt to load contriution id from invoiceID
598 ([19511](https://github.com/civicrm/civicrm-core/pull/19511))**
599
600 - **[REF] Stop passing contributionPageID to isEmailReceipt
601 ([19498](https://github.com/civicrm/civicrm-core/pull/19498))**
602
603 - **[NFC] Fix PHP 7.4 Syntax issue in Afform HTML Extension
604 ([19477](https://github.com/civicrm/civicrm-core/pull/19477))**
605
606 - **[NFC] Update composer.lock
607 ([19485](https://github.com/civicrm/civicrm-core/pull/19485))**
608
609 - **[NFC] Whitespace fix up
610 ([19408](https://github.com/civicrm/civicrm-core/pull/19408))**
611
612 - **[NFC] Preliminary cleanup
613 ([19401](https://github.com/civicrm/civicrm-core/pull/19401))**
614
615 - **NFC Minor code cleanup to contribution pages
616 ([19468](https://github.com/civicrm/civicrm-core/pull/19468))**
617
618 - **[NFC] minor code cleanups
619 ([19366](https://github.com/civicrm/civicrm-core/pull/19366))**
620
621 - **[NFC] Update contributor-key.yml with Ahed
622 ([19378](https://github.com/civicrm/civicrm-core/pull/19378))**
623
624 - **[NFC] Minor code cleanup
625 ([19367](https://github.com/civicrm/civicrm-core/pull/19367))**
626
627 - **[NFC] Move Upgrade for navgation from 5.34.alpha1 to 5.35.alpha1 as t…
628 ([19364](https://github.com/civicrm/civicrm-core/pull/19364))**
629
630 - **(NFC) Regenerate civicrm_generated.mysql
631 ([19363](https://github.com/civicrm/civicrm-core/pull/19363))**
632
633 - **[NFC] - Remove literally empty if block
634 ([632](https://github.com/civicrm/civicrm-drupal/pull/632))**
635
636 - **[NFC] Update Schema Handler to use the standard create table syntax of using
637 `ROW_FORMAT=dynamic`
638 ([19705](https://github.com/civicrm/civicrm-core/pull/19705))**
639
640 ## <a name="credits"></a>Credits
641
642 This release was developed by the following code authors:
643
644 AGH Strategies - Alice Frumin, Andie Hunt; Agileware - Justin Freeman;
645 Christian Wach; CiviCoop - Jaap Jansma, Klaas Eikelboom; CiviCRM - Coleman
646 Watts, Tim Otten; CiviDesk - Yashodha Chaku; CompuCorp - Ahed Eid; Coop
647 SymbioTIC - Mathieu Lutfy; Dave D; ECOPLAN - Torben Bertram; Freeform
648 Solutions - Herb van den Dool; iXiam - Vangelis Pantazis; JMA Consulting -
649 Seamus Lee; John Kingsnorth; Megaphone Technology Consulting - Jon Goldberg; MJW
650 Consulting - Matthew Wire; Skvare - Sunil Pawar; Stephen Palmstrom; Wikimedia
651 Foundation - Eileen McNaughton
652
653 Most authors also reviewed code for this release; in addition, the following
654 reviewers contributed their comments:
655
656 Agileware - Justin Freeman; Artful Robot - Rich Lott; Blackfly Solutions - Alan
657 Dixon; Fuzion - Jitendra Purohit; JMA Consulting - Monish Deb; MJCO - Mikey
658 O'Toole; StijnVanhandsaeme; Tadpole Collective - Kevin Cristiano
659
660 ## <a name="feedback"></a>Feedback
661
662 These release notes are edited by Alice Frumin and Andie Hunt. If you'd like
663 to provide feedback on them, please log in to https://chat.civicrm.org/civicrm
664 and contact `@agh1`.